Opened 5 years ago

Closed 5 years ago

#20405 closed defect (fixed)

Let (indexed) monoids know they are finitely generated

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-7.2
Component: categories Keywords:
Cc: sage-combinat, nthiery Merged in:
Authors: Travis Scrimshaw Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: 740cf79 (Commits) Commit: 740cf79cd75cabd0135897543bdcad788a543705
Dependencies: #20403 Stopgaps:

Description

Right now, free (indexed) monoids do not know they are finitely generated (when the index set is finite of course), meaning that they cannot use the generic iteration. We fix this here.

Change History (8)

comment:1 Changed 5 years ago by tscrim

  • Branch set to public/monoids/free_monoids_finitely_generated-20405
  • Commit set to ee0536e6528ab48d3e146277a9e15bb85cbb0672
  • Status changed from new to needs_review

New commits:

​ee0536eAdded (indexed) monoids to finitely generated monoids category.

comment:2 Changed 5 years ago by git

  • Commit changed from ee0536e6528ab48d3e146277a9e15bb85cbb0672 to c95e024b950cf660c5a13ddbfc6793167f01b62c

Branch pushed to git repo; I updated commit sha1. New commits:

​c95e024Fixing trivial failing doctests due to new iterator.

comment:3 Changed 5 years ago by git

  • Commit changed from c95e024b950cf660c5a13ddbfc6793167f01b62c to e6402496bad187ba92f21d3f3bd46f74e488908f

Branch pushed to git repo; I updated commit sha1. New commits:

​e640249Last fix of doctests.

comment:4 Changed 5 years ago by tscrim

  • Dependencies set to #20403

comment:5 Changed 5 years ago by git

  • Commit changed from e6402496bad187ba92f21d3f3bd46f74e488908f to e7914d4060cb7b1cb7429a09654bb4eb34f64adc

Branch pushed to git repo; I updated commit sha1. New commits:

​a0307f3Changed iterator for finitely generated semigroups.
​c427ca9Change TODO list in backtrack to state we can deprecate TransitiveIdeal* now.
​a27f383trac #20403 fixing one doctest
​c20562etrac #20403 doc formatting
​1c07d56Merge branch 'public/semigroups/iterator_finitely_generated_semigroups-20403' of trac.sagemath.org:sage into public/monoids/free_monoids_finitely_generated-20405
​e7914d4Pulling changes from #17039 to fix doctest with this (#20405) + #20403.

comment:6 Changed 5 years ago by git

  • Commit changed from e7914d4060cb7b1cb7429a09654bb4eb34f64adc to 740cf79cd75cabd0135897543bdcad788a543705

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​b07dfe2Doc of the two implementationsof ActiveTaskCounter
​beebcbc#13580: Added comment on timing in the doc
​58eca2e#13580: Removed comment which is now in the doc
​1badd8a#13580: Renamed ActiveTaskCounter(Posix)
​46cbab913580: Fixed doctests to pass on Darwin
​134c1fa13580: doc rereading
​4c82d1bMerge branch 'u/hivert/ticket/13580' of trac.sagemath.org:sage into u/hivert/ticket/13580
​67521ddMerge branch 'u/hivert/ticket/13580' into public/semigroups/iterator_finitely_generated_semigroups-20403
​6272efdRemoving tab character.
​740cf79Merge branch 'public/semigroups/iterator_finitely_generated_semigroups-20403' into public/monoids/free_monoids_finitely_generated-20405

comment:7 Changed 5 years ago by saraedum

  • Reviewers set to Julian Rüth
  • Status changed from needs_review to positive_review

One patchbot complains about startup time. Another one is fine with it and I do not see how this could cause an increased startup time.

comment:8 Changed 5 years ago by vbraun

  • Branch changed from public/monoids/free_monoids_finitely_generated-20405 to 740cf79cd75cabd0135897543bdcad788a543705
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.