Opened 4 years ago

Closed 4 years ago

#20392 closed enhancement (fixed)

Add a list of packages to download for sdist in Makefile

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.2
Component: distribution Keywords: days77
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: c0e42dd (Commits) Commit: c0e42dd93df5634d4b53bff4e1e7beeda881dca7
Dependencies: Stopgaps:

Description

Change this from build/make/deps 

download-for-sdist: base
    env SAGE_INSTALL_FETCH_ONLY=yes $(MAKE) -B SAGERUNTIME= \
        $(STANDARD_PACKAGES) gcc mpir python2

to use a new variable $(SDIST_PACKAGES) such that we can change $(STANDARD_PACKAGES) without affecting the sdist tarball.

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/add_a_list_of_packages_to_download_for_sdist_in_makefile

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to c0e42dd93df5634d4b53bff4e1e7beeda881dca7
  • Status changed from new to needs_review

New commits:

​c0e42ddNew SDIST_PACKAGES make variable for packages to appear in sdist

comment:3 Changed 4 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/add_a_list_of_packages_to_download_for_sdist_in_makefile to c0e42dd93df5634d4b53bff4e1e7beeda881dca7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.