Opened 3 years ago

Closed 3 years ago

#20367 closed defect (fixed)

fix integer option and a bug in Delsarte bounds code

Reported by: dimpase Owned by:
Priority: major Milestone: sage-7.2
Component: coding theory Keywords: lp
Cc: mkoeppe Merged in:
Authors: Dima Pasechnik Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: eb15d11 (Commits) Commit: eb15d119d3f57873b5de9a4d2bddb932a4c4f316
Dependencies: #20351, #20354, #20361 Stopgaps:

Description

with PPL providing MIP solver thanks to #20354 and #20351, it becomes important to have an option to ask for integer solutions only. A silly bug is fixed along the way.

Change History (6)

comment:1 Changed 3 years ago by git

  • Commit set to 115092cde127128f756ceb74a606dee55d3e5cfd

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​728750fCVXOPTBackend.add_variables: Pass arguments to add_variable, correct default for lower_bound
​b4a8ed7Copy new CVXOPTBackend.add_variables tests to other backends
​b0d89e4GLPKBackend.add_variables: Set column names correctly
​183ce25PPLBackend.add_variable, add_variables: Don't silently ignore binary=True, integer=True
​e47b608CVXOPTBackend.add_linear_constraints: Add doctest, simplify code
​b0179c2Merge branch 't/20303/fixes_for_the_cvxopt_mip_backend' into t/20354/pplbackend__add_support_for_integer_variables
​144a970PPLBackend: Add support for integer variables
​df42b5bFix for #20361: PPL backend re-solves the problem every time get_variable_value or get_objective_value is called
​1931b2aMerge branch 'u/mkoeppe/ppl_backend_re_solves_the_problem_every_time_get_variable_value_or_get_objective_value_is_called' of git://trac.sagemath.org/sage into delsartefix
​115092cproper handling of isinteger parameter, new doctest

comment:2 Changed 3 years ago by dimpase

  • Cc mkoeppe added
  • Dependencies changed from #20351, #20354 to #20351, #20354, #20361
  • Status changed from new to needs_review

Last 10 new commits:

​728750fCVXOPTBackend.add_variables: Pass arguments to add_variable, correct default for lower_bound
​b4a8ed7Copy new CVXOPTBackend.add_variables tests to other backends
​b0d89e4GLPKBackend.add_variables: Set column names correctly
​183ce25PPLBackend.add_variable, add_variables: Don't silently ignore binary=True, integer=True
​e47b608CVXOPTBackend.add_linear_constraints: Add doctest, simplify code
​b0179c2Merge branch 't/20303/fixes_for_the_cvxopt_mip_backend' into t/20354/pplbackend__add_support_for_integer_variables
​144a970PPLBackend: Add support for integer variables
​df42b5bFix for #20361: PPL backend re-solves the problem every time get_variable_value or get_objective_value is called
​1931b2aMerge branch 'u/mkoeppe/ppl_backend_re_solves_the_problem_every_time_get_variable_value_or_get_objective_value_is_called' of git://trac.sagemath.org/sage into delsartefix
​115092cproper handling of isinteger parameter, new doctest

comment:3 Changed 3 years ago by mkoeppe

delsarte_bound_additive_hamming_space should perhaps have a test involving isinteger=True?

Looking at the file, perhaps the English transliteration Kravchuk should be made an alias for the French transliteration Krawtchouk?

comment:4 Changed 3 years ago by git

  • Commit changed from 115092cde127128f756ceb74a606dee55d3e5cfd to eb15d119d3f57873b5de9a4d2bddb932a4c4f316

Branch pushed to git repo; I updated commit sha1. New commits:

​eb15d11added Kravchuk and tests

comment:5 Changed 3 years ago by mkoeppe

  • Keywords lp added
  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/dimpase/delsartefix to eb15d119d3f57873b5de9a4d2bddb932a4c4f316
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.