Opened 3 years ago
Closed 3 years ago
#20367 closed defect (fixed)
fix integer option and a bug in Delsarte bounds code
Reported by:  dimpase  Owned by:  

Priority:  major  Milestone:  sage7.2 
Component:  coding theory  Keywords:  lp 
Cc:  mkoeppe  Merged in:  
Authors:  Dima Pasechnik  Reviewers:  Matthias Koeppe 
Report Upstream:  N/A  Work issues:  
Branch:  eb15d11 (Commits)  Commit:  eb15d119d3f57873b5de9a4d2bddb932a4c4f316 
Dependencies:  #20351, #20354, #20361  Stopgaps: 
Change History (6)
comment:1 Changed 3 years ago by
 Commit set to 115092cde127128f756ceb74a606dee55d3e5cfd
comment:2 Changed 3 years ago by
 Cc mkoeppe added
 Dependencies changed from #20351, #20354 to #20351, #20354, #20361
 Status changed from new to needs_review
Last 10 new commits:
728750f  CVXOPTBackend.add_variables: Pass arguments to add_variable, correct default for lower_bound

b4a8ed7  Copy new CVXOPTBackend.add_variables tests to other backends

b0d89e4  GLPKBackend.add_variables: Set column names correctly

183ce25  PPLBackend.add_variable, add_variables: Don't silently ignore binary=True, integer=True

e47b608  CVXOPTBackend.add_linear_constraints: Add doctest, simplify code

b0179c2  Merge branch 't/20303/fixes_for_the_cvxopt_mip_backend' into t/20354/pplbackend__add_support_for_integer_variables

144a970  PPLBackend: Add support for integer variables

df42b5b  Fix for #20361: PPL backend resolves the problem every time get_variable_value or get_objective_value is called

1931b2a  Merge branch 'u/mkoeppe/ppl_backend_re_solves_the_problem_every_time_get_variable_value_or_get_objective_value_is_called' of git://trac.sagemath.org/sage into delsartefix

115092c  proper handling of isinteger parameter, new doctest

comment:3 Changed 3 years ago by
delsarte_bound_additive_hamming_space
should perhaps have a test involving isinteger=True
?
Looking at the file, perhaps the English transliteration Kravchuk
should be made an alias for the French transliteration Krawtchouk
?
comment:4 Changed 3 years ago by
 Commit changed from 115092cde127128f756ceb74a606dee55d3e5cfd to eb15d119d3f57873b5de9a4d2bddb932a4c4f316
Branch pushed to git repo; I updated commit sha1. New commits:
eb15d11  added Kravchuk and tests

comment:5 Changed 3 years ago by
 Keywords lp added
 Reviewers set to Matthias Koeppe
 Status changed from needs_review to positive_review
comment:6 Changed 3 years ago by
 Branch changed from u/dimpase/delsartefix to eb15d119d3f57873b5de9a4d2bddb932a4c4f316
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
CVXOPTBackend.add_variables: Pass arguments to add_variable, correct default for lower_bound
Copy new CVXOPTBackend.add_variables tests to other backends
GLPKBackend.add_variables: Set column names correctly
PPLBackend.add_variable, add_variables: Don't silently ignore binary=True, integer=True
CVXOPTBackend.add_linear_constraints: Add doctest, simplify code
Merge branch 't/20303/fixes_for_the_cvxopt_mip_backend' into t/20354/pplbackend__add_support_for_integer_variables
PPLBackend: Add support for integer variables
Fix for #20361: PPL backend resolves the problem every time get_variable_value or get_objective_value is called
Merge branch 'u/mkoeppe/ppl_backend_re_solves_the_problem_every_time_get_variable_value_or_get_objective_value_is_called' of git://trac.sagemath.org/sage into delsartefix
proper handling of isinteger parameter, new doctest