Opened 6 years ago

Closed 5 years ago

#20365 closed enhancement (worksforme)

allow building with unpatched cython

Reported by: jcristau Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: cython Keywords:
Cc: fbissey Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Currently sage adds two patches on top of cython 0.23.4.p0. One of them is upstream but not yet in a release, the other one was, as I understand it, rejected by cython upstream. As far as I can tell, both can be rather cheaply avoided, allowing to build sage with an unpatched release version of cython.

Attachments (1)

0001-monkeypatch-cython-instead-of-requiring-a-patched-ve.patch​ (1.1 KB) - added by jcristau 6 years ago.
monkeypatch Cython.Compiler.Main.Context.find_include_file

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by jcristau

monkeypatch Cython.Compiler.Main.Context.find_include_file

comment:1 Changed 6 years ago by fbissey

  • Cc fbissey added

comment:2 Changed 6 years ago by jdemeyer

There is actually a simpler patch possible, see ​http://cysignals.readthedocs.org/en/latest/#basic-example

comment:3 Changed 5 years ago by jdemeyer

  • Milestone changed from sage-7.2 to sage-duplicate/invalid/wontfix
  • Resolution set to worksforme
  • Reviewers set to Jeroen Demeyer
  • Status changed from new to closed

This Cython patch is needed to support cross-package include statements. The current plan is to remove those include statements. Then Sage will build without that patch. I have been working on this, the last remaining piece is #23195.

Note: See TracTickets for help on using tickets.