Opened 6 years ago
Closed 6 years ago
#20353 closed enhancement (fixed)
Move sphinxify to Sage
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage7.2 
Component:  documentation  Keywords:  days77 
Cc:  hivert  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  John Palmieri 
Report Upstream:  N/A  Work issues:  
Branch:  71a7cb6 (Commits, GitHub, GitLab)  Commit:  71a7cb61bcde4ea859c8bc52f2d42dde0af1f305 
Dependencies:  Stopgaps: 
Description
The file src/sage/misc/sagedoc.py
imports sphinxify
from sagenb. This is bad, since sagenb should not be a dependency for the Sage documentation.
Change History (8)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
 Branch set to u/jdemeyer/uncouple_documentation_builder_from_sagenb
comment:3 Changed 6 years ago by
 Commit set to 4b206a21763c644797a30c48dfe426fc1d43078c
 Status changed from new to needs_review
 Summary changed from Uncouple documentation builder from sagenb to Move sphinxify to Sage
comment:4 Changed 6 years ago by
 Keywords days77 added
comment:5 Changed 6 years ago by
I think this could use one more change:

src/doc/en/reference/misc/index.rst
diff git a/src/doc/en/reference/misc/index.rst b/src/doc/en/reference/misc/index.rst index 3fcd5b0..10a0a1d 100644
a b Interactive Sage Sessions 226 226 sage/misc/viewer 227 227 sage/misc/pager 228 228 sage/misc/sagedoc 229 sage/misc/sphinxify 229 230 230 231 Distribution 231 232 ~~~~~~~~~~~~
Then I think it's ready to go.
comment:6 Changed 6 years ago by
 Commit changed from 4b206a21763c644797a30c48dfe426fc1d43078c to 71a7cb61bcde4ea859c8bc52f2d42dde0af1f305
Branch pushed to git repo; I updated commit sha1. New commits:
71a7cb6  Add sphinxify to the documentation

comment:7 Changed 6 years ago by
 Reviewers set to John Palmieri
 Status changed from needs_review to positive_review
comment:8 Changed 6 years ago by
 Branch changed from u/jdemeyer/uncouple_documentation_builder_from_sagenb to 71a7cb61bcde4ea859c8bc52f2d42dde0af1f305
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Move sphinxify to Sage