Opened 6 years ago

Closed 6 years ago

#20353 closed enhancement (fixed)

Move sphinxify to Sage

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.2
Component: documentation Keywords: days77
Cc: hivert Merged in:
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 71a7cb6 (Commits, GitHub, GitLab) Commit: 71a7cb61bcde4ea859c8bc52f2d42dde0af1f305
Dependencies: Stopgaps:

Status badges

Description

The file src/sage/misc/sagedoc.py imports sphinxify from sagenb. This is bad, since sagenb should not be a dependency for the Sage documentation.

Change History (8)

comment:1 Changed 6 years ago by jdemeyer

  • Authors set to Jeroen Demeyer

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/uncouple_documentation_builder_from_sagenb

comment:3 Changed 6 years ago by jdemeyer

  • Commit set to 4b206a21763c644797a30c48dfe426fc1d43078c
  • Status changed from new to needs_review
  • Summary changed from Uncouple documentation builder from sagenb to Move sphinxify to Sage

New commits:

4b206a2Move sphinxify to Sage

comment:4 Changed 6 years ago by slelievre

  • Keywords days77 added

comment:5 Changed 6 years ago by jhpalmieri

I think this could use one more change:

  • src/doc/en/reference/misc/index.rst

    diff --git a/src/doc/en/reference/misc/index.rst b/src/doc/en/reference/misc/index.rst
    index 3fcd5b0..10a0a1d 100644
    a b Interactive Sage Sessions 
    226226   sage/misc/viewer
    227227   sage/misc/pager
    228228   sage/misc/sagedoc
     229   sage/misc/sphinxify
    229230
    230231Distribution
    231232~~~~~~~~~~~~

Then I think it's ready to go.

comment:6 Changed 6 years ago by git

  • Commit changed from 4b206a21763c644797a30c48dfe426fc1d43078c to 71a7cb61bcde4ea859c8bc52f2d42dde0af1f305

Branch pushed to git repo; I updated commit sha1. New commits:

71a7cb6Add sphinxify to the documentation

comment:7 Changed 6 years ago by jdemeyer

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/uncouple_documentation_builder_from_sagenb to 71a7cb61bcde4ea859c8bc52f2d42dde0af1f305
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.