Opened 7 years ago

Closed 7 years ago

#20352 closed enhancement (fixed)

Initialize PARI constants in PariInstance.__init__

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.2
Component: interfaces Keywords: days77
Cc: Luca De Feo Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9d2865b (Commits, GitHub, GitLab) Commit: 9d2865b41b02e4e05ba3bdbac7506b72d92adff7
Dependencies: Stopgaps:

Status badges

Description


Change History (7)

comment:1 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/20352

comment:2 Changed 7 years ago by Jeroen Demeyer

Commit: e33844fbb485598f38a6f3df6ae3256219517c02
Status: newneeds_review

New commits:

e33844fInitialize PARI constants in PariInstance.__init__

comment:3 Changed 7 years ago by Travis Scrimshaw

Could you clarify the comment about PARI_* being global variables? As least in this code they are class level variables. I'm guessing they are global variables for PARI?

comment:4 Changed 7 years ago by git

Commit: e33844fbb485598f38a6f3df6ae3256219517c029d2865b41b02e4e05ba3bdbac7506b72d92adff7

Branch pushed to git repo; I updated commit sha1. New commits:

9d2865bFix comment

comment:5 Changed 7 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Thanks.

comment:6 Changed 7 years ago by Samuel Lelièvre

Keywords: days77 added

comment:7 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/ticket/203529d2865b41b02e4e05ba3bdbac7506b72d92adff7
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.