Opened 5 years ago

Closed 5 years ago

#20352 closed enhancement (fixed)

Initialize PARI constants in PariInstance.__init__

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.2
Component: interfaces Keywords: days77
Cc: defeo Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9d2865b (Commits, GitHub, GitLab) Commit: 9d2865b41b02e4e05ba3bdbac7506b72d92adff7
Dependencies: Stopgaps:

Status badges

Description


Change History (7)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/20352

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to e33844fbb485598f38a6f3df6ae3256219517c02
  • Status changed from new to needs_review

New commits:

e33844fInitialize PARI constants in PariInstance.__init__

comment:3 Changed 5 years ago by tscrim

Could you clarify the comment about PARI_* being global variables? As least in this code they are class level variables. I'm guessing they are global variables for PARI?

comment:4 Changed 5 years ago by git

  • Commit changed from e33844fbb485598f38a6f3df6ae3256219517c02 to 9d2865b41b02e4e05ba3bdbac7506b72d92adff7

Branch pushed to git repo; I updated commit sha1. New commits:

9d2865bFix comment

comment:5 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks.

comment:6 Changed 5 years ago by slelievre

  • Keywords days77 added

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/20352 to 9d2865b41b02e4e05ba3bdbac7506b72d92adff7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.