#20344 closed enhancement (fixed)
Remove some deprecated modules
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage7.2 
Component:  misc  Keywords:  
Cc:  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  474a78d (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Change History (13)
comment:1 Changed 6 years ago by
 Description modified (diff)
comment:2 Changed 6 years ago by
 Description modified (diff)
comment:3 Changed 6 years ago by
 Description modified (diff)
comment:4 Changed 6 years ago by
 Branch set to u/jdemeyer/remove_some_deprecated_modules
comment:5 Changed 6 years ago by
 Commit set to a67df31d141b7aa40b90323729e9230bf52625ad
 Status changed from new to needs_review
comment:6 Changed 6 years ago by
 Reviewers set to Vincent Delecroix
 Status changed from needs_review to needs_work
Pickling issues (see patchbot report)
comment:7 Changed 6 years ago by
 Commit changed from a67df31d141b7aa40b90323729e9230bf52625ad to 474a78dc1ac661552b3e0ea3638ff6237ec6f0b6
Branch pushed to git repo; I updated commit sha1. New commits:
474a78d  Fix unpickling MatrixSpace_ZZ_2x2

comment:8 Changed 6 years ago by
 Status changed from needs_work to needs_review
comment:9 Changed 6 years ago by
 Status changed from needs_review to positive_review
comment:10 Changed 6 years ago by
 Branch changed from u/jdemeyer/remove_some_deprecated_modules to 474a78dc1ac661552b3e0ea3638ff6237ec6f0b6
 Resolution set to fixed
 Status changed from positive_review to closed
comment:11 Changed 6 years ago by
 Commit 474a78dc1ac661552b3e0ea3638ff6237ec6f0b6 deleted
This breaks SageTeX.
comment:12 Changed 6 years ago by
That's the problem with deprecation warnings: it's apparently very easy to miss them.
The relevant deprecation was added in #17396 (17 months ago) and released in Sage 6.5 (14 months ago).
comment:13 Changed 6 years ago by
In this case, many (most?) SageTeX users would have it used automagically within a GUI frontend like I do, where one doesn't see things like this in the log file because it zooms by so very quickly and more relevant messages are the ones at the bottom, like TeX errors ;)
Anyway, I'm not saying we should not have merged this, I'm just saying we shouldn't release Sage 7.2 without fixing SageTeX. #19072 would fix it.
(Which, by the way, is a perfect example of an outsourced pkg with an independent maintainer that has just been left behind by this. Modularization, anyone?)
New commits:
Remove deprecated modules