Opened 6 years ago

Closed 6 years ago

#20341 closed enhancement (fixed)

Add to_digraph method to RecursivelyEnumeratedSet

Reported by: slabbe Owned by:
Priority: major Milestone: sage-7.2
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Sébastien Labbé Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c9a8067 (Commits, GitHub, GitLab) Commit: c9a8067565cc8f74d65cea6d08419c53506a2e2c
Dependencies: Stopgaps:

Status badges

Description

sage: f = lambda a: [a+1, a+I] 
sage: C = RecursivelyEnumeratedSet([0], f, structure='graded') 
sage: C.to_digraph(max_depth=4)  
Looped multi-digraph on 21 vertices 

Change History (6)

comment:1 Changed 6 years ago by slabbe

  • Branch set to u/slabbe/20341
  • Commit set to 2c36bbb685084ae6f137e40a3435183c3abcc700
  • Status changed from new to needs_review

New commits:

2c36bbb#20341: adding to_digraph to recursively_enumerated_set

comment:2 Changed 6 years ago by git

  • Commit changed from 2c36bbb685084ae6f137e40a3435183c3abcc700 to 86fe5cef16365cdd896df09fe24f6c5e5291946c

Branch pushed to git repo; I updated commit sha1. New commits:

86fe5ce20341: adding to_digraph to recursively_enumerated_set

comment:3 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

A few small things:

  • Make Default -> default and remove the period from the first input?
  • De-indent the output.
  • Change .. NOTE:: to .. WARNING::.

LGTM otherwise. So once you make those changes, you can set a positive review on my behalf.

comment:4 Changed 6 years ago by git

  • Commit changed from 86fe5cef16365cdd896df09fe24f6c5e5291946c to c9a8067565cc8f74d65cea6d08419c53506a2e2c

Branch pushed to git repo; I updated commit sha1. New commits:

c9a806720341: fixing reviewer comments

comment:5 Changed 6 years ago by slabbe

  • Status changed from needs_review to positive_review

comment:6 Changed 6 years ago by vbraun

  • Branch changed from u/slabbe/20341 to c9a8067565cc8f74d65cea6d08419c53506a2e2c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.