Opened 3 years ago

Closed 3 years ago

#20332 closed defect (fixed)

CVXOPTBackend: Set initial problem_name

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-7.2
Component: numerical Keywords: lp
Cc: dimpase, ingolfured, vdelecroix, jdemeyer Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: f1af4ec (Commits) Commit: f1af4ec3eb834260c90a0da1b96873185f528ab3
Dependencies: Stopgaps:

Description

CVXOPTBackend forgets to set its initial problem_name, and as a result the MixedIntegerLinearProgram cannot print itself.

sage: p = MixedIntegerLinearProgram(solver="CVXOPT")
sage: p
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
...
TypeError: cannot concatenate 'str' and 'NoneType' objects
<repr(<sage.numerical.mip.MixedIntegerLinearProgram at 0x190970a70>) failed: TypeError: cannot concatenate 'str' and 'NoneType' objects>

Change History (8)

comment:1 Changed 3 years ago by mkoeppe

  • Branch set to u/mkoeppe/cvxoptbackend__set_initial_problem_name

comment:2 Changed 3 years ago by mkoeppe

  • Commit set to eb4649c7aba9ba9ac31c8db6598353865dac37e8
  • Status changed from new to needs_review

New commits:

eb4649cCVXOPTBackend: Set initial problem_name

comment:3 Changed 3 years ago by mkoeppe

... needs review ...

comment:4 Changed 3 years ago by dimpase

Can we have a doctest showing that this fixes the error in the ticket description?

comment:5 Changed 3 years ago by git

  • Commit changed from eb4649c7aba9ba9ac31c8db6598353865dac37e8 to f1af4ec3eb834260c90a0da1b96873185f528ab3

Branch pushed to git repo; I updated commit sha1. New commits:

f1af4ecCVXOPTBackend: Add test for #20232

comment:6 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

ok, good to go.

comment:7 Changed 3 years ago by mkoeppe

  • Authors set to Matthias Koeppe

Thanks for reviewing, Dima!

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/mkoeppe/cvxoptbackend__set_initial_problem_name to f1af4ec3eb834260c90a0da1b96873185f528ab3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.