Opened 6 years ago

Closed 6 years ago

#20306 closed enhancement (fixed)

some more trac links corrected

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-7.2
Component: documentation Keywords: beginner
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 2da15bd (Commits, GitHub, GitLab) Commit: 2da15bdbfdcaf2362d9f5f792723d76076d0bdb3
Dependencies: Stopgaps:

Status badges

Description

let us fix a few more links to trac tickets in the doc

Change History (12)

comment:1 Changed 6 years ago by chapoton

  • Branch set to public/20306
  • Commit set to 2dc36c6d43cefb0c3acd349fec6762525a760374
  • Keywords beginner added
  • Status changed from new to needs_review

New commits:

2dc36c6fixgin a bunch of trac links in the doc

comment:2 Changed 6 years ago by git

  • Commit changed from 2dc36c6d43cefb0c3acd349fec6762525a760374 to a55a953e4a8eaf8534692ba72581ea29b63ba5f4

Branch pushed to git repo; I updated commit sha1. New commits:

a55a953one missing colon

comment:3 Changed 6 years ago by git

  • Commit changed from a55a953e4a8eaf8534692ba72581ea29b63ba5f4 to ba7854e16ded16186e044051840982bcdf012964

Branch pushed to git repo; I updated commit sha1. New commits:

ba7854etrac #20306 fix failing doctests

comment:4 Changed 6 years ago by vdelecroix

Why this

  • src/sage/modular/modform/element.py

    diff --git a/src/sage/modular/modform/element.py b/src/sage/modular/modform/element.py
    index d88df81..b0e04f3 100644
    a b class ModularForm_abstract(ModuleElement): 
    900900            sage: phi = K.embeddings(RR)[0]
    901901            sage: L = F.symsquare_lseries(embedding=phi)
    902902            sage: L(5)
    903             verbose -1 (370: dokchitser.py, __call__) Warning: Loss of 8 decimal digits due to cancellation
     903            verbose -1 (371: dokchitser.py, __call__) Warning: Loss of 8 decimal digits due to cancellation
    904904            -3.57698266793901e19
    905905
    906906        TESTS::
    class ModularForm_abstract(ModuleElement): 
    10041004        EXAMPLE::
    10051005
    10061006            sage: CuspForms(1, 16).0.petersson_norm()
    1007             verbose -1 (370: dokchitser.py, __call__) Warning: Loss of 2 decimal digits due to cancellation
     1007            verbose -1 (371: dokchitser.py, __call__) Warning: Loss of 2 decimal digits due to cancellation
    10081008            2.16906134759063e-6
    10091009
    10101010        The Petersson norm depends on a choice of embedding::

comment:5 Changed 6 years ago by chapoton

because these were failing doctests.

comment:6 Changed 6 years ago by mmezzarobba

Tickets of this kind tend to cause conflicts once merged, and I don't really see the point of writing :trac:... instead of #... (even in new code)...

comment:7 follow-up: Changed 6 years ago by tscrim

I think a better solution to those verbose lines would be

verbose -1 (...: dokchitser.py, __call__) Warning: Loss of 2 decimal digits due to cancellation

so as to avoid this problem in the future due to the number of lines changing in dokchitser.py.

@mmezzarobba The reason why this is good is because when the doc is built, it automatically provides an embedded link to the trac ticket.

comment:8 Changed 6 years ago by git

  • Commit changed from ba7854e16ded16186e044051840982bcdf012964 to 2da15bdbfdcaf2362d9f5f792723d76076d0bdb3

Branch pushed to git repo; I updated commit sha1. New commits:

23d33dcMerge branch 'public/20306' into 7.2.b1
2da15bdtrac #20306 better handling of doctest failing

comment:9 in reply to: ↑ 7 ; follow-up: Changed 6 years ago by mmezzarobba

Replying to tscrim:

@mmezzarobba The reason why this is good is because when the doc is built, it automatically provides an embedded link to the trac ticket.

Sure, I understand that one might want to use that in new code for this reason. But if that's important enough to do it even in code that you don't have any other reason to touch, wouldn't it be possible to teach the docbuilder the syntax #number instead?

comment:10 in reply to: ↑ 9 Changed 6 years ago by tscrim

Replying to mmezzarobba:

Replying to tscrim:

@mmezzarobba The reason why this is good is because when the doc is built, it automatically provides an embedded link to the trac ticket.

Sure, I understand that one might want to use that in new code for this reason. But if that's important enough to do it even in code that you don't have any other reason to touch, wouldn't it be possible to teach the docbuilder the syntax #number instead?

Until you want to have something like "If we do #1, then..." in the doc. IMO, basic doc maintenance is good to do and trivial merge conflicts like this, while annoying, are easy enough to deal with.

comment:11 Changed 6 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:12 Changed 6 years ago by vbraun

  • Branch changed from public/20306 to 2da15bdbfdcaf2362d9f5f792723d76076d0bdb3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.