#20305 closed enhancement (fixed)
Typo fixes to vertex_separation.pyx
Reported by: | zgershkoff | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | sage-7.2 |
Component: | graph theory | Keywords: | |
Cc: | Stefan | Merged in: | |
Authors: | Zach Gershkoff | Reviewers: | Julian Rüth |
Report Upstream: | N/A | Work issues: | |
Branch: | 8fc3088 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description
I fixed a couple of typos in the documentation of vertex separation. The change can be found at https://github.com/sagemath/sage/pull/57
Change History (14)
comment:1 Changed 6 years ago by
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
comment:3 Changed 6 years ago by
- Cc Stefan added
- Status changed from needs_review to needs_work
comment:4 Changed 6 years ago by
- Branch set to typos
comment:5 Changed 6 years ago by
- Branch changed from typos to u/zgershkoff/typos
- Commit set to c6904435dd508813afae9b2881441ca5ee4154b4
comment:6 Changed 6 years ago by
I'm unable to access the branch u/zgershkoff/typos
and so I cannot help yet reviewing the patch.
David.
comment:7 Changed 6 years ago by
+1. The branch appears to have no commits.
comment:8 Changed 6 years ago by
- Commit changed from c6904435dd508813afae9b2881441ca5ee4154b4 to 8fc3088435ed26ac70cfb063f2e8897e1aaa1c2c
Branch pushed to git repo; I updated commit sha1. New commits:
8fc3088 | I downloaded the repository to my office computer and changed the file. Now I'm trying to cmmit the change.
|
comment:9 Changed 6 years ago by
- Status changed from needs_work to needs_review
It seems that I've made the commit and pushed it correctly so I'll change the ticket status to 'needs review'.
comment:10 Changed 6 years ago by
- Reviewers set to Julian Rüth
- Status changed from needs_review to positive_review
The commit message is somewhat unfortunate but I guess it is not really a problem. (you are probably aware that "fixed typo" would have been better.)
comment:11 Changed 6 years ago by
Yes, I saw that in the guide after I pushed the commit. Thank you!
comment:12 Changed 6 years ago by
- Branch changed from u/zgershkoff/typos to 8fc3088435ed26ac70cfb063f2e8897e1aaa1c2c
- Resolution set to fixed
- Status changed from positive_review to closed
comment:13 Changed 5 years ago by
- Commit 8fc3088435ed26ac70cfb063f2e8897e1aaa1c2c deleted
unique name please
Hi Zach,
Please follow the SageMath Developer's Guide to upload your branch to Trac correctly, either by using the "git-trac" command or by looking at the "git the hard way" section. See:
http://doc.sagemath.org/html/en/developer/git_trac.html