Opened 7 years ago

Closed 7 years ago

#20299 closed enhancement (fixed)

Binary tarball sanity check when running make

Reported by: Volker Braun Owned by:
Priority: major Milestone: sage-7.2
Component: build Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: ff163cd (Commits, GitHub, GitLab) Commit: ff163cd81a4355c102de003cabdcc5ddcc599290
Dependencies: Stopgaps:

Status badges

Description (last modified by Volker Braun)

I don't understand why anybody would download a binary tarball and then run "make" as the first command, but a steady trickle of support requests proves me wrong. So just execute ./relocate-once.py if it exists, and nobody gets harmed.

Change History (7)

comment:1 Changed 7 years ago by Volker Braun

Branch: u/vbraun/binary_tarball_sanity_check_when_running_make

comment:2 Changed 7 years ago by Volker Braun

Authors: Volker Braun
Commit: 92737a99568c015e84f6921a50b06a5bf71c794d
Component: PLEASE CHANGEbuild
Description: modified (diff)
Status: newneeds_review
Type: PLEASE CHANGEenhancement

New commits:

92737a9Support running make in a fresh binary tarball

comment:3 Changed 7 years ago by Jeroen Demeyer

Branch: u/vbraun/binary_tarball_sanity_check_when_running_makeu/jdemeyer/binary_tarball_sanity_check_when_running_make

comment:4 Changed 7 years ago by git

Commit: 92737a99568c015e84f6921a50b06a5bf71c794dff163cd81a4355c102de003cabdcc5ddcc599290

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ff163cdSupport running make in a fresh binary tarball

comment:5 Changed 7 years ago by Jeroen Demeyer

I think this way is much better, since it also supports running sage -i pkg, which in turn runs $MAKE all-toolchain and $MAKE pkg.

comment:6 Changed 7 years ago by Volker Braun

Authors: Volker BraunJeroen Demeyer
Reviewers: Volker Braun
Status: needs_reviewpositive_review

comment:7 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/binary_tarball_sanity_check_when_running_makeff163cd81a4355c102de003cabdcc5ddcc599290
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.