Opened 2 years ago

Closed 2 years ago

#20291 closed enhancement (fixed)

Upgrade fplll to newest development version

Reported by: malb Owned by:
Priority: major Milestone: sage-7.2
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Martin Albrecht Reviewers: François Bissey, Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 269fd25 (Commits) Commit: 269fd25cac4c4d032cefd651fc1f4dada3b220c7
Dependencies: Stopgaps:

Description (last modified by malb)

This enables the use of fpylll from within Sage.

tarball: http://trac.sagemath.org/raw-attachment/ticket/20291/libfplll-20160331.tar.gz

Attachments (1)

libfplll-20160331.tar.gz (481.2 KB) - added by malb 2 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 2 years ago by malb

  • Description modified (diff)

comment:2 Changed 2 years ago by malb

  • Description modified (diff)

comment:3 Changed 2 years ago by malb

  • Branch set to u/malb/t20219-libfplll
  • Commit set to 3709eaeb4f08c07f94ab02b0670c1074e6fcbd03
  • Status changed from new to needs_review

New commits:

3709eaelibfplll-20160325

comment:4 Changed 2 years ago by fbissey

We don't attach tarball to tickets anymore.

comment:5 Changed 2 years ago by malb

Well, I need to put the tarball somewhere (upstream doesn't publish tarballs right now)

Changed 2 years ago by malb

comment:6 Changed 2 years ago by malb

  • Description modified (diff)

comment:7 follow-up: Changed 2 years ago by fbissey

If upstream doesn't provide any tarball, this is a snapshot you made yourself from the git repo. Could you make a spkg-src so making the tarball is somewhat reproducible?

comment:8 Changed 2 years ago by git

  • Commit changed from 3709eaeb4f08c07f94ab02b0670c1074e6fcbd03 to 5369226abbef6513bc9a692ebe4d8fa52dc4a1b2

Branch pushed to git repo; I updated commit sha1. New commits:

5369226upgrade libfplll to 20160331

comment:9 Changed 2 years ago by git

  • Commit changed from 5369226abbef6513bc9a692ebe4d8fa52dc4a1b2 to 2c0460863cc6ffb874252a1450e8fd885c1fad91

Branch pushed to git repo; I updated commit sha1. New commits:

2c04608add spkg-src for libfplll

comment:10 in reply to: ↑ 7 Changed 2 years ago by malb

Replying to fbissey:

If upstream doesn't provide any tarball, this is a snapshot you made yourself from the git repo. Could you make a spkg-src so making the tarball is somewhat reproducible?

Makes sense, I've added it.

comment:11 Changed 2 years ago by jdemeyer

In spkg-src, why not use

FPLLL_SAGE_VERSION=`cat package-version.txt |sed 's/[.]p.*//'`

(after the cd $SPKG_ROOT obviously)

comment:12 Changed 2 years ago by jdemeyer

  • Status changed from needs_review to needs_work

More importantly: checkout a specific commit instead of using whatever git clone gives by default. Otherwise it's not reproducible at all.

And write your name as author on this ticket.

Last edited 2 years ago by jdemeyer (previous) (diff)

comment:13 Changed 2 years ago by git

  • Commit changed from 2c0460863cc6ffb874252a1450e8fd885c1fad91 to 269fd25cac4c4d032cefd651fc1f4dada3b220c7

Branch pushed to git repo; I updated commit sha1. New commits:

269fd25libfplll: fix fplll revision

comment:14 Changed 2 years ago by malb

  • Authors set to Martin Albrecht
  • Status changed from needs_work to needs_review

comment:15 Changed 2 years ago by malb

Hi there, can I tempt anyone to review this?

comment:16 follow-up: Changed 2 years ago by fbissey

doctesting now. Pity the patchbot gets confused by that one.

comment:17 in reply to: ↑ 16 Changed 2 years ago by vdelecroix

Replying to fbissey:

doctesting now. Pity the patchbot gets confused by that one.

Patchbot never tests package related stuff. How could it ever found the tarball?

comment:18 Changed 2 years ago by fbissey

  • Reviewers set to François Bissey, Jeroen Demeyer
  • Status changed from needs_review to positive_review

OK to send to the bots.

comment:19 Changed 2 years ago by vbraun

  • Branch changed from u/malb/t20219-libfplll to 269fd25cac4c4d032cefd651fc1f4dada3b220c7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.