Opened 2 years ago

Closed 2 years ago

#20289 closed enhancement (fixed)

pep8 cleanup in game_theory

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-7.2
Component: game theory Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6a5df50 (Commits) Commit: 6a5df504ccfc61e86519a28ac13a6736b3b52526
Dependencies: Stopgaps:


just to correct a typo and a few pep8 details in game_theory

Change History (5)

comment:1 Changed 2 years ago by chapoton

  • Branch set to public/20289
  • Commit set to e34a81f55b098830c18320577f5669a9d8a16746
  • Status changed from new to needs_review

New commits:

e34a81ffull pep8 in game_theory

comment:2 Changed 2 years ago by tscrim

It looks good overall except for this change:

-    g = AntiCoordinationGame(A=v/2-c, a=v/2-c, B=0, b=v, C=v, c=0, D=v/2, d=v/2)
+    g = AntiCoordinationGame(A=v / 2 - c, a=v / 2 - c, B=0, b=v,
+                             C=v, c=0, D=v / 2, d=v / 2)

I think it makes it less readable and is one of those cases where we should not follow PEP8 to the letter.

comment:3 Changed 2 years ago by git

  • Commit changed from e34a81f55b098830c18320577f5669a9d8a16746 to 6a5df504ccfc61e86519a28ac13a6736b3b52526

Branch pushed to git repo; I updated commit sha1. New commits:

83cef7cMerge branch 'public/20289' into 7.2.b0
6a5df50trac #20289 reviewer's comment

comment:4 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thank you.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from public/20289 to 6a5df504ccfc61e86519a28ac13a6736b3b52526
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.