Opened 6 years ago

Closed 6 years ago

#20286 closed defect (fixed)

Constructing matrix from numpy ignores ring

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.2
Component: linear algebra Keywords:
Cc: vdelecroix Merged in:
Authors: Jeroen Demeyer Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 80ed2fb (Commits, GitHub, GitLab) Commit: 80ed2fbaa4099cc1fa0507df86bbeae195b13eb1
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

sage: M = matrix(QQ, 2, 2, [1, 1/2, 1/3, 1/4])
sage: M
[  1 1/2]
[1/3 1/4]
sage: matrix(QQ, M.numpy())
[               1.0                0.5]
[0.3333333333333333               0.25]

The latter should give a matrix over QQ.

Change History (4)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/constructing_matrix_from_numpy_ignores_ring

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 80ed2fbaa4099cc1fa0507df86bbeae195b13eb1
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

80ed2fbUse ring when constructing a matrix from numpy

comment:3 Changed 6 years ago by mmezzarobba

  • Reviewers set to Marc Mezzarobba
  • Status changed from needs_review to positive_review

comment:4 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/constructing_matrix_from_numpy_ignores_ring to 80ed2fbaa4099cc1fa0507df86bbeae195b13eb1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.