Opened 3 years ago

Closed 3 years ago

#20285 closed defect (fixed)

make OSX binary distros useful for development

Reported by: dimpase Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: distribution Keywords:
Cc: cremona Merged in:
Authors: Volker Braun Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by dimpase)

see the discussion here: https://groups.google.com/d/msg/sage-devel/Q76TxYT7vaU/N2Yp7JELDgAJ

OSX binary installs do not allow installing extra packages (breaking after make is run).

To reproduce (as described in the posts linked):

download binary distro (to an OSX machine with Sage dev environment ready), install it by untarring and running ./sage once.

Then do

./sage -i gap_packages make

get an error and ./sage that crashes

Change History (14)

comment:1 Changed 3 years ago by vbraun

  • Status changed from new to needs_info

Steps to reproduce?

comment:2 Changed 3 years ago by dimpase

  • Description modified (diff)

comment:3 Changed 3 years ago by dimpase

  • Status changed from needs_info to needs_work

comment:4 Changed 3 years ago by vbraun

$ pkg-config --libs gsl
/Users/vbraun/Desktop/SageMath/local/bin/pkg-config: line 16: /Users/buildslave-sage/slave/binary_pkg/build/tools/binary-pkg/bin/pkg-config: No such file or directory
/Users/vbraun/Desktop/SageMath/local/bin/pkg-config: line 16: exec: /Users/buildslave-sage/slave/binary_pkg/build/tools/binary-pkg/bin/pkg-config: cannot execute: No such file or directory

The compile step picks up the binary builder's tools. We should scrub the path before executing the compile script.

comment:5 Changed 3 years ago by dimpase

well, I need to read on pkg-config, and understand its role in Sage, before I can make full sense of this comment.

comment:6 Changed 3 years ago by vbraun

I'll take care of it

comment:7 Changed 3 years ago by vbraun

  • Authors set to Volker Braun
  • Milestone changed from sage-7.2 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

Fixed in https://github.com/sagemath/binary-pkg/commit/8f412120497816727429fd1905ced094f660ffcb

PS: the patching step is much faster now if you haven't noticed yet...

comment:8 Changed 3 years ago by dimpase

Yes, I noticed that patching is faster. How do you want this to be reviewed? I can test some tarballs on OSX.

Something else - IMHO a tighter integration of binary-pkg with Sage would be great. Perhaps via a git submodule?

comment:9 follow-up: Changed 3 years ago by vbraun

I uploaded updated OSX tarballs (for beta0)

IMHO tooling should not be integrated, it sounds good but really you are going to bite your own tail all the time. For starters, its written in Python 3 and uses some python packages that are not part of Sage (and don't make any sense in Sage). Of course you are welcome to review the code on github...

There is nothing to be done here, just close as "fixed".

comment:10 in reply to: ↑ 9 Changed 3 years ago by dimpase

Replying to vbraun:

I uploaded updated OSX tarballs (for beta0)

IMHO tooling should not be integrated, it sounds good but really you are going to bite your own tail all the time.

I did not say "integrating into Sage". I meant "make it less weird to use, and easier to install properly". (Same applies to git trac, by the way). They are parts of a wider "Sage dev/release tools" project, and I only have arguments for it to be less loose than it is now, so that just one or two git commands in the Sage repo is all you need to get them installed/updated; less strictly necessary reading to do to configure them properly (e.g. currently we have an unwritten requirement that binary-pkg must not be installed via git to be useful, cf https://github.com/sagemath/binary-pkg/issues/6)

They would remain quite independent from Sage, with their own requirements etc.

comment:11 Changed 3 years ago by dimpase

  • Status changed from needs_review to positive_review

comment:12 follow-up: Changed 3 years ago by vbraun

git-trac can be installed as a Sage optional package, what else do you want?

Having binary-pkg in Sage would mean that its dependencies would also become packaged in binary tarballs.

comment:13 in reply to: ↑ 12 Changed 3 years ago by dimpase

Replying to vbraun:

git-trac can be installed as a Sage optional package, what else do you want?

ah, I didn't even know that, or forgot. I assumed it is in the same status as binary-pkg. (I'd say it's a bit of a bloat...)

Having binary-pkg in Sage would mean that its dependencies would also become packaged in binary tarballs.

Again, I do not say "make it a Sage package".

comment:14 Changed 3 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.