Opened 7 years ago

Closed 7 years ago

#20279 closed enhancement (fixed)

Homogeneous coordinates of polyhedron V-representation objects

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.2
Component: geometry Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: fd495ec (Commits, GitHub, GitLab) Commit: fd495ec341336ed6460c5db480263795ed52ab8e
Dependencies: Stopgaps:

Status badges

Description

To implement group actions on polyhedra, one usually wants affine groups. This acts on homogeneous coordinates. For vertices, this is the coordinates with a 1 appended. For rays and lines, this is the coordinates with a 0 appended.

Change History (6)

comment:1 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/homogeneous_coordinates_of_polyhedron_v_representation_objects

comment:2 Changed 7 years ago by Jeroen Demeyer

Commit: ba8723abd6e77d9e9b0cacbcf9f124cd974968bb
Status: newneeds_review

New commits:

ba8723aHomogeneous coordinates of polyhedron V-representation objects

comment:3 Changed 7 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

One minor thing. Because the fact that the first sentence is telling what each method returns and the second is describing what that object is. I feel that the second sentence should not be in that short initial description, but instead in a second paragraph. I don't hold a strong opinion on this, so whether you make the changes or disagree, you can set a positive review on my behalf.

comment:4 Changed 7 years ago by git

Commit: ba8723abd6e77d9e9b0cacbcf9f124cd974968bbfd495ec341336ed6460c5db480263795ed52ab8e

Branch pushed to git repo; I updated commit sha1. New commits:

fd495ecImprove documentation of homogeneous_vector()

comment:5 Changed 7 years ago by Jeroen Demeyer

Status: needs_reviewpositive_review

comment:6 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/homogeneous_coordinates_of_polyhedron_v_representation_objectsfd495ec341336ed6460c5db480263795ed52ab8e
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.