Opened 7 years ago

Closed 7 years ago

#20269 closed defect (fixed)

Inconsistent return types in real_roots

Reported by: mmezzarobba Owned by:
Priority: trivial Milestone: sage-7.2
Component: algebra Keywords:
Cc: Merged in:
Authors: Marc Mezzarobba Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 4b339aa (Commits, GitHub, GitLab) Commit: 4b339aa6a424c2609c83e88bd7c72b4514337997
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description

real_roots returns int(0) instead of QQ(0) in some cases.

Change History (11)

comment:1 Changed 7 years ago by mmezzarobba

Status: new → needs_review

comment:2 Changed 7 years ago by vdelecroix

Please add a reference to the ticket number in the doctest.

comment:3 Changed 7 years ago by vdelecroix

Reviewers: → Vincent Delecroix

comment:4 Changed 7 years ago by git

Commit: 9c54af02da479e7be16150ffb4e0e6a24aeb3021 → e9761ee42b6c96a53e1a7c0d5bf4617e33cf40da

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​e9761eereal_roots: fix return type inconsistency

comment:5 Changed 7 years ago by vdelecroix

Old school boy: #20269 -> :trac:`20269` ;-)

comment:6 Changed 7 years ago by git

Commit: e9761ee42b6c96a53e1a7c0d5bf4617e33cf40da → e93432a4a632aef28e5dd1f7500b8504e7ce65a9

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​e93432a#20269 real_roots: fix return type inconsistency

comment:7 Changed 7 years ago by vdelecroix

Status: needs_review → positive_review

Good to go!

comment:8 Changed 7 years ago by vbraun

Status: positive_review → needs_work

Merge conflict with #20202

comment:9 Changed 7 years ago by git

Commit: e93432a4a632aef28e5dd1f7500b8504e7ce65a9 → 4b339aa6a424c2609c83e88bd7c72b4514337997

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​4b339aa#20269 real_roots: fix return type inconsistency

comment:10 Changed 7 years ago by vdelecroix

Status: needs_work → positive_review

comment:11 Changed 7 years ago by vbraun

Branch: u/mmezzarobba/real_roots_parent → 4b339aa6a424c2609c83e88bd7c72b4514337997
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.