Opened 4 years ago

Last modified 6 months ago

#20265 needs_work enhancement

Hasse-Weil Zeta function of hypersurfaces, deformation method

Reported by: edgarcosta Owned by:
Priority: major Milestone: sage-pending
Component: padics Keywords: days71, sd87, days88, sd91
Cc: kedlaya Merged in:
Authors: Edgar Costa, Jan Tuitman Reviewers: Edgar Costa
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #23466, #23498 Stopgaps:

Description

We plan to add a wrapper for Sebastian pancratz's code, ​https://github.com/SPancratz/deformation

Change History (22)

comment:2 Changed 3 years ago by roed

  • Keywords sd87 added

comment:4 Changed 3 years ago by jpflori

  • Dependencies set to #23466

Created #23466 to add some bindings for flint.

comment:5 Changed 3 years ago by jpflori

  • Dependencies changed from #23466 to #23466, #23498

comment:6 Changed 3 years ago by jpflori

Wrapper should now be pip installable.

comment:7 Changed 3 years ago by edgarcosta

  • Status changed from new to needs_review

This should be closed down. See #23498

comment:8 Changed 3 years ago by edgarcosta

  • Reviewers set to Edgar Costa
  • Status changed from needs_review to positive_review

comment:9 Changed 3 years ago by roed

  • Milestone changed from sage-7.2 to sage-duplicate/invalid/wontfix

comment:10 Changed 3 years ago by jpflori

  • Milestone changed from sage-duplicate/invalid/wontfix to sage-pending
  • Status changed from positive_review to needs_work

I think we should still do the pypi package a sage's optional package (with a folder in build/pkgs), just like cysignals.

comment:11 Changed 3 years ago by edgarcosta

  • Keywords days88 added

I don't follow. Isn't pydeformation a PyPI package?

comment:12 Changed 3 years ago by kedlaya

  • Cc kedlaya added

comment:13 Changed 3 years ago by kedlaya

Can someone in the know clarify the status of this? Is this now made redundant by other tickets?

comment:14 Changed 3 years ago by jpflori

At the moment we have:

  • Sebastian C code as an optional package,
  • my skinny wrapper as a pip installable package.

So the installation procedure is:

  • ./sage -i deformation to install the former
  • ./sage -python pip install pydeformation for the latter (or maybe ./sage -pip ...)

I'd say it would be nice to make pydeformation a sage optional package so that you can use Sage dependency system to just do

  • ./sage -i pydeformation and that it automagically installs the optional deformation C library first.

As deformation is a C library (of interest without the wrapper), I don't want to ship it within the wrapper, nor would it be a good idea to make it a pip installable thing (to be able to use pip dependency system).

comment:15 Changed 3 years ago by edgarcosta

Would it make sense to create a meta package that depends on both of those packages?

comment:16 Changed 3 years ago by jpflori

You mean a Sage package? I don't see the point, can you give further details?

Note that when I say a sage optional package for pydeformation I really mean just creating a folder in build/pkg with simple spkg-install script as for cysignals.

comment:17 Changed 3 years ago by edgarcosta

Yes, I meant a Sage package. It was just a quick (and perhaps dirty) way to get deformation and pydeformation in sage.

Anyhow, I have no experience with sage packages. But let me know if there is anything I can do to help you.

comment:18 follow-up: Changed 3 years ago by jpflori

Nah I just need to find one hour to make a branch. Should be ok by the end of the week.

comment:19 in reply to: ↑ 18 Changed 3 years ago by roed

Replying to jpflori:

Nah I just need to find one hour to make a branch. Should be ok by the end of the week.

Ping.

comment:20 Changed 3 years ago by jpflori

Long. Work and life took over... Hopefully I ll get to it soon.

comment:21 Changed 3 years ago by kedlaya

  • Keywords sd91 added

comment:22 Changed 6 months ago by kedlaya

Ping. Doesn't look like the underlying code has been touched since this ticket was created.

Note: See TracTickets for help on using tickets.