Opened 7 years ago
Last modified 2 months ago
#20265 needs_work enhancement
HasseWeil Zeta function of hypersurfaces, deformation method
Reported by:  Edgar Costa  Owned by:  

Priority:  major  Milestone:  sagepending 
Component:  padics  Keywords:  days71, sd87, days88, sd91 
Cc:  Kiran Kedlaya  Merged in:  
Authors:  Edgar Costa, Jan Tuitman  Reviewers:  Edgar Costa 
Report Upstream:  N/A  Work issues:  
Branch:  public/hasse_weil_pydeformation (Commits, GitHub, GitLab)  Commit:  d682f442eac4994bfed4dee80ef2c2d07c4edba9 
Dependencies:  #23466, #23498  Stopgaps: 
Description
We plan to add a wrapper for Sebastian pancratz's code, https://github.com/SPancratz/deformation
Change History (23)
comment:1 Changed 7 years ago by
comment:2 Changed 5 years ago by
Keywords:  sd87 added 

comment:3 Changed 5 years ago by
Updated code at: https://github.com/jpflori/deformation and hackish binding at: https://github.com/jpflori/pydeformation
comment:4 Changed 5 years ago by
Dependencies:  → #23466 

Created #23466 to add some bindings for flint.
comment:5 Changed 5 years ago by
Dependencies:  #23466 → #23466, #23498 

comment:8 Changed 5 years ago by
Reviewers:  → Edgar Costa 

Status:  needs_review → positive_review 
comment:9 Changed 5 years ago by
Milestone:  sage7.2 → sageduplicate/invalid/wontfix 

comment:10 Changed 5 years ago by
Milestone:  sageduplicate/invalid/wontfix → sagepending 

Status:  positive_review → needs_work 
I think we should still do the pypi package a sage's optional package (with a folder in build/pkgs
), just like cysignals.
comment:11 Changed 5 years ago by
Keywords:  days88 added 

I don't follow.
Isn't pydeformation
a PyPI package?
comment:12 Changed 5 years ago by
Cc:  Kiran Kedlaya added 

comment:13 Changed 5 years ago by
Can someone in the know clarify the status of this? Is this now made redundant by other tickets?
comment:14 Changed 5 years ago by
At the moment we have:
 Sebastian C code as an optional package,
 my skinny wrapper as a pip installable package.
So the installation procedure is:
./sage i deformation
to install the former./sage python pip install pydeformation
for the latter (or maybe./sage pip ...
)
I'd say it would be nice to make pydeformation
a sage optional package so that you can use Sage dependency system to just do
./sage i pydeformation
and that it automagically installs the optionaldeformation
C library first.
As deformation
is a C library (of interest without the wrapper), I don't want to ship it within the wrapper, nor would it be a good idea to make it a pip installable thing (to be able to use pip dependency system).
comment:15 Changed 5 years ago by
Would it make sense to create a meta package that depends on both of those packages?
comment:16 Changed 5 years ago by
You mean a Sage package? I don't see the point, can you give further details?
Note that when I say a sage optional package for pydeformation
I really mean just creating a folder in build/pkg
with simple spkginstall
script as for cysignals.
comment:17 Changed 5 years ago by
Yes, I meant a Sage package. It was just a quick (and perhaps dirty) way to get deformation and pydeformation in sage.
Anyhow, I have no experience with sage packages. But let me know if there is anything I can do to help you.
comment:18 followup: 19 Changed 5 years ago by
Nah I just need to find one hour to make a branch. Should be ok by the end of the week.
comment:19 Changed 5 years ago by
Replying to jpflori:
Nah I just need to find one hour to make a branch. Should be ok by the end of the week.
Ping.
comment:21 Changed 5 years ago by
Keywords:  sd91 added 

comment:22 Changed 3 years ago by
Ping. Doesn't look like the underlying code has been touched since this ticket was created.
comment:23 Changed 2 months ago by
Branch:  → public/hasse_weil_pydeformation 

Commit:  → d682f442eac4994bfed4dee80ef2c2d07c4edba9 
here is a first sketch of pkg information, not yet correct
New commits:
d682f44  sketch of package info for pydeformation

Here is a preliminary version of the wrapper: https://github.com/edgarcosta/deformation/commit/273ecbb43f6ce28cc0c025c07e40e1dc6eb708a4