Opened 6 years ago

Closed 6 years ago

#20235 closed enhancement (fixed)

Enable warnings when compiling Sage library

Reported by: jdemeyer Owned by:
Priority: trivial Milestone: sage-7.2
Component: build Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: e60d14f (Commits, GitHub, GitLab) Commit: e60d14ff8a8c6c8fccf8440aba7ebbadb638cd7a
Dependencies: Stopgaps:

Status badges

Description

We really should not suppress all warnings when compiling the Sage library. Many of these warnings point to genuine problems in the code.

Change History (8)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/enable_warnings_when_compiling_sage_library

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 4023df409562cbc81402eedf1b9d28d2fac48c81
  • Status changed from new to needs_review

New commits:

​4023df4Enable warnings when compiling the Sage library

comment:3 follow-up: Changed 6 years ago by git

  • Commit changed from 4023df409562cbc81402eedf1b9d28d2fac48c81 to e60d14ff8a8c6c8fccf8440aba7ebbadb638cd7a

Branch pushed to git repo; I updated commit sha1. New commits:

​e60d14fDrop -pedantic from CFLAGS

comment:4 in reply to: ↑ 3 Changed 6 years ago by aapitzsch

Replying to git:

Branch pushed to git repo; I updated commit sha1. New commits:

​e60d14fDrop -pedantic from CFLAGS

Why have you removed the -pedantic flag from m4ri?

comment:5 follow-up: Changed 6 years ago by jdemeyer

With -pedantic you get way too many useless warnings.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 6 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

Replying to jdemeyer:

With -pedantic you get way too many useless warnings.

But that's only for the m4ri package, isn't it?

Anyway, it's fine with me.

comment:7 in reply to: ↑ 6 Changed 6 years ago by jdemeyer

Replying to aapitzsch:

But that's only for the m4ri package, isn't it?

It's for Cython extensions using m4ri.

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/enable_warnings_when_compiling_sage_library to e60d14ff8a8c6c8fccf8440aba7ebbadb638cd7a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.