Opened 7 years ago

Closed 7 years ago

#20217 closed enhancement (fixed)

Remove redundant functions from pari_instance.pyx

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.1
Component: interfaces Keywords:
Cc: Luca De Feo Merged in:
Authors: Jeroen Demeyer Reviewers: Luca De Feo
Report Upstream: N/A Work issues:
Branch: d7d2d7d (Commits, GitHub, GitLab) Commit: d7d2d7df24760cdecf0d6585972d2bf6140c1123
Dependencies: #20210, #20205, #20213, #20216 Stopgaps:

Status badges

Description

Many functions in src/sage/libs/pari/pari_instance.pyx are just manual copies of auto-generated code. Remove those functions, but keep the doctests in src/sage/libs/pari/tests.py.

Change History (6)

comment:1 Changed 7 years ago by Jeroen Demeyer

Dependencies: #20210, #20205, #20213, #20216

comment:2 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/remove_redundant_functions_from_pari_instance_pyx

comment:3 Changed 7 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer
Commit: d7d2d7df24760cdecf0d6585972d2bf6140c1123
Status: newneeds_review

New commits:

03458eaUpgrade cysignals package
dce67fcMove memory functions to cysignals
4bb8337Rename sage_malloc -> sig_malloc and friends
5ab73c1Get rid of factorint_withproof_sage in PARI interface
c0ed97aStop using deprecated PARI factoring features
edc5ce2Merge branch 't/20205/get_rid_of_factorint_withproof_sage_in_pari_interface' into HEAD
5fb408dReplace pari_catch_sig_on by sig_on
d5c934cDeprecate PARI nth_prime and prime_list
d7d2d7dRemove redundant functions from pari_instance.pyx

comment:4 Changed 7 years ago by Luca De Feo

I just doctested this. All tests pass.

I suggest one more removal: default(self, variable, value=None).

comment:5 Changed 7 years ago by Luca De Feo

Reviewers: Luca De Feo
Status: needs_reviewpositive_review

Since the default function is to be dealt in #20224, I have no more objections.

comment:6 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/remove_redundant_functions_from_pari_instance_pyxd7d2d7df24760cdecf0d6585972d2bf6140c1123
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.