Opened 4 years ago

Closed 4 years ago

#20216 closed enhancement (fixed)

Deprecate PARI nth_prime, prime_list, primes_up_to_n

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.1
Component: interfaces Keywords:
Cc: defeo Merged in:
Authors: Jeroen Demeyer Reviewers: Luca De Feo
Report Upstream: N/A Work issues:
Branch: e4858c6 (Commits) Commit: e4858c69f9f5e5e07a8577f96d844265dddd9c52
Dependencies: #20210, #20205, #20213 Stopgaps:

Description (last modified by jdemeyer)

Use the standard PARI/GP names prime() and primes() instead.

Change History (15)

comment:1 Changed 4 years ago by jdemeyer

  • Dependencies changed from #20213 to #20210, #20205, #20213

comment:2 Changed 4 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Deprecate PARI nth_prime to Deprecate PARI nth_prime and prime_list

comment:3 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 4 years ago by jdemeyer

  • Summary changed from Deprecate PARI nth_prime and prime_list to Deprecate PARI nth_prime, prime_list, primes_up_to_n

comment:7 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/deprecate_pari_nth_prime

comment:8 Changed 4 years ago by jdemeyer

  • Commit set to d5c934c5164255e352cee9ddbc780d0759b6e185
  • Status changed from new to needs_review

New commits:

03458eaUpgrade cysignals package
dce67fcMove memory functions to cysignals
4bb8337Rename sage_malloc -> sig_malloc and friends
5ab73c1Get rid of factorint_withproof_sage in PARI interface
c0ed97aStop using deprecated PARI factoring features
edc5ce2Merge branch 't/20205/get_rid_of_factorint_withproof_sage_in_pari_interface' into HEAD
5fb408dReplace pari_catch_sig_on by sig_on
d5c934cDeprecate PARI nth_prime and prime_list

comment:9 Changed 4 years ago by defeo

Shouldn't the doc

Return the vector of the first `n` primes, the primes in the
interval `[n, end]` or the list of primes up to `end`.

read

Return the pari vector of the first `n` primes, the primes in the
interval `[n, end]` or the pari vector of primes up to `end`.

instead?

comment:10 Changed 4 years ago by defeo

  • Branch changed from u/jdemeyer/deprecate_pari_nth_prime to u/defeo/deprecate_pari_nth_prime

comment:11 Changed 4 years ago by defeo

  • Commit changed from d5c934c5164255e352cee9ddbc780d0759b6e185 to 7355781bf73e5798224ddfce2283e7e4dae3a436

I made the rewording. This ticket is good to go for me.


New commits:

7355781Reworded docstring

comment:12 Changed 4 years ago by git

  • Commit changed from 7355781bf73e5798224ddfce2283e7e4dae3a436 to e4858c69f9f5e5e07a8577f96d844265dddd9c52

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e4858c6Reworded docstring

comment:13 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to needs_work

comment:14 Changed 4 years ago by defeo

  • Reviewers set to Luca De Feo
  • Status changed from needs_work to positive_review

Oups, sorry for the indentation nonsense.

comment:15 Changed 4 years ago by vbraun

  • Branch changed from u/defeo/deprecate_pari_nth_prime to e4858c69f9f5e5e07a8577f96d844265dddd9c52
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.