Opened 7 years ago

Closed 7 years ago

#20213 closed enhancement (fixed)

Replace pari_catch_sig_on by sig_on

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.1
Component: cython Keywords:
Cc: Luca De Feo, Peter Bruin Merged in:
Authors: Jeroen Demeyer Reviewers: Luca De Feo
Report Upstream: N/A Work issues:
Branch: 5fb408d (Commits, GitHub, GitLab) Commit: 5fb408dedb22e4147ee68ae5656e643b4f1df06c
Dependencies: #20210, #20205 Stopgaps:

Status badges


There is no longer a reason to have pari_catch_sig_on() separate from plain sig_on().

Change History (6)

comment:1 Changed 7 years ago by Jeroen Demeyer

Dependencies: #20210

comment:2 Changed 7 years ago by Jeroen Demeyer

Dependencies: #20210#20210, #20205

comment:3 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/20213

comment:4 Changed 7 years ago by Jeroen Demeyer

Commit: 5fb408dedb22e4147ee68ae5656e643b4f1df06c
Status: newneeds_review

New commits:

03458eaUpgrade cysignals package
dce67fcMove memory functions to cysignals
4bb8337Rename sage_malloc -> sig_malloc and friends
5ab73c1Get rid of factorint_withproof_sage in PARI interface
c0ed97aStop using deprecated PARI factoring features
edc5ce2Merge branch 't/20205/get_rid_of_factorint_withproof_sage_in_pari_interface' into HEAD
5fb408dReplace pari_catch_sig_on by sig_on

comment:5 Changed 7 years ago by Luca De Feo

Reviewers: Luca De Feo
Status: needs_reviewpositive_review

Doctests pass, I can Ctrl-C pari function calls, and grep does not find any occurence of pari_catch_sig_o(n|ff). So I guess this can go in.

comment:6 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/ticket/202135fb408dedb22e4147ee68ae5656e643b4f1df06c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.