Opened 4 years ago

Closed 4 years ago

#20213 closed enhancement (fixed)

Replace pari_catch_sig_on by sig_on

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.1
Component: cython Keywords:
Cc: defeo, pbruin Merged in:
Authors: Jeroen Demeyer Reviewers: Luca De Feo
Report Upstream: N/A Work issues:
Branch: 5fb408d (Commits) Commit: 5fb408dedb22e4147ee68ae5656e643b4f1df06c
Dependencies: #20210, #20205 Stopgaps:

Description

There is no longer a reason to have pari_catch_sig_on() separate from plain sig_on().

Change History (6)

comment:1 Changed 4 years ago by jdemeyer

  • Dependencies set to #20210

comment:2 Changed 4 years ago by jdemeyer

  • Dependencies changed from #20210 to #20210, #20205

comment:3 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/20213

comment:4 Changed 4 years ago by jdemeyer

  • Commit set to 5fb408dedb22e4147ee68ae5656e643b4f1df06c
  • Status changed from new to needs_review

New commits:

​03458eaUpgrade cysignals package
​dce67fcMove memory functions to cysignals
​4bb8337Rename sage_malloc -> sig_malloc and friends
​5ab73c1Get rid of factorint_withproof_sage in PARI interface
​c0ed97aStop using deprecated PARI factoring features
​edc5ce2Merge branch 't/20205/get_rid_of_factorint_withproof_sage_in_pari_interface' into HEAD
​5fb408dReplace pari_catch_sig_on by sig_on

comment:5 Changed 4 years ago by defeo

  • Reviewers set to Luca De Feo
  • Status changed from needs_review to positive_review

Doctests pass, I can Ctrl-C pari function calls, and grep does not find any occurence of pari_catch_sig_o(n|ff). So I guess this can go in.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/20213 to 5fb408dedb22e4147ee68ae5656e643b4f1df06c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.