Opened 6 years ago

Closed 6 years ago

#20208 closed defect (fixed)

Keep system libraries in pkgconf

Reported by: vbraun Owned by:
Priority: major Milestone: sage-7.2
Component: packages: standard Keywords:
Cc: fbissey, dimpase Merged in:
Authors: Volker Braun Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 20e1893 (Commits, GitHub, GitLab) Commit: 20e1893be906c209464abad840eaf116a3e533d5
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

By default, our self-built pkgconf binary will strip out SAGE_LOCAL/lib and SAGE_LOCAL/include since it considers these system paths. This patch keeps these paths.

Change History (6)

comment:1 Changed 6 years ago by vbraun

  • Branch set to u/vbraun/keep_system_libraries_in_pkgconf

comment:2 Changed 6 years ago by vbraun

  • Cc fbissey dimpase added
  • Commit set to 20e1893be906c209464abad840eaf116a3e533d5
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

20e1893Do not strip out system libs in pkg-config

comment:3 Changed 6 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Looks good to me.

comment:4 Changed 6 years ago by vbraun

  • Authors set to Volker Braun

comment:5 Changed 6 years ago by fbissey

  • Milestone changed from sage-7.1 to sage-7.2

comment:6 Changed 6 years ago by vbraun

  • Branch changed from u/vbraun/keep_system_libraries_in_pkgconf to 20e1893be906c209464abad840eaf116a3e533d5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.