Opened 7 years ago

Closed 7 years ago

#20205 closed enhancement (fixed)

Clean up factoring PARI interface

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.1
Component: interfaces Keywords:
Cc: Luca De Feo Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: c0ed97a (Commits, GitHub, GitLab) Commit: c0ed97a0b2a036c3a4677d8e5dbabf6b2a6d54fc
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

  1. Instead of manually checking primality, we should just use PARI's factor_proven default.
  1. Stop using deprecated PARI features like factor0() and lim=0.

Change History (9)

comment:1 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/get_rid_of_factorint_withproof_sage_in_pari_interface

comment:2 Changed 7 years ago by git

Commit: 5ab73c1c098478da766a061109a2a248d741e49e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5ab73c1Get rid of factorint_withproof_sage in PARI interface

comment:3 Changed 7 years ago by Jeroen Demeyer

Status: newneeds_review

comment:4 Changed 7 years ago by Jeroen Demeyer

Status: needs_reviewneeds_work

comment:5 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Get rid of factorint_withproof_sage in PARI interfaceClean up factoring PARI interface

comment:6 Changed 7 years ago by git

Commit: 5ab73c1c098478da766a061109a2a248d741e49ec0ed97a0b2a036c3a4677d8e5dbabf6b2a6d54fc

Branch pushed to git repo; I updated commit sha1. New commits:

c0ed97aStop using deprecated PARI factoring features

comment:7 Changed 7 years ago by Jeroen Demeyer

Status: needs_workneeds_review

comment:8 Changed 7 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

good to go!

comment:9 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/get_rid_of_factorint_withproof_sage_in_pari_interfacec0ed97a0b2a036c3a4677d8e5dbabf6b2a6d54fc
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.