Opened 6 years ago

Closed 8 months ago

#20203 closed enhancement (invalid)

LPCleanDictionary - floating-point helper class for interactive simplex method

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: numerical Keywords:
Cc: zwang, pjxiao Merged in:
Authors: Aedi Wang Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: u/mkoeppe/lpcleandictionary___floating_point_helper_class_for_interactive_simplex_method (Commits, GitHub, GitLab) Commit: ae348f72c23ea49043f135424da06c2e456cbf8c
Dependencies: #20874 Stopgaps:

Status badges

Description

This module provides a "clean" dictionary view on a dictionary with floating-point numbers. Cleaning means to change almost-zeros to exact zeros, allowing the Interactive Simplex Method to recognize primal and dual feasibility and to avoid pivoting on zero pivot elements.

(Split out from the larger ticket #18804.)

Change History (17)

comment:1 Changed 6 years ago by mkoeppe

  • Branch set to u/mkoeppe/lpcleandictionary___floating_point_helper_class_for_interactive_simplex_method

comment:2 Changed 6 years ago by mkoeppe

  • Cc zwang added
  • Commit set to 24eaba360ddb9f6c114315a412ec28684beff117

To be done:

  • Tests should be based on normal dictionaries, not the backend dictionaries from #18804
  • Perhaps have InteractiveLPProblem use LPCleanDictionary automatically when field is inexact

New commits:

​24eaba3clean_dictionary.py copied from f45615c

comment:3 Changed 6 years ago by git

  • Commit changed from 24eaba360ddb9f6c114315a412ec28684beff117 to 067b75db3d800f28daa67248213024c5a7803a6d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​067b75dclean_dictionary.py copied from f45615c

comment:4 Changed 6 years ago by git

  • Commit changed from 067b75db3d800f28daa67248213024c5a7803a6d to 2e4496b7598ba2c01ea10a24361e5e2be7b9ef16

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2e4496bclean_dictionary.py copied from f45615c

comment:5 Changed 6 years ago by zwang

  • Branch changed from u/mkoeppe/lpcleandictionary___floating_point_helper_class_for_interactive_simplex_method to u/zwang/lpcleandictionary___floating_point_helper_class_for_interactive_simplex_method

comment:6 Changed 6 years ago by mkoeppe

  • Commit changed from 2e4496b7598ba2c01ea10a24361e5e2be7b9ef16 to 7bdddd4bf4a0b4681f300c156b62afdf832c9ec0
  • Dependencies set to #20874

New commits:

​6cad314add objective_name() to dictionary interface
​288e6f7Doc fix
​62b9ec6clean_dictionary.py copied from f45615c
​7bdddd4revise doc tests and implementation to use LPDictionary

comment:7 Changed 6 years ago by mkoeppe

  • Branch changed from u/zwang/lpcleandictionary___floating_point_helper_class_for_interactive_simplex_method to u/mkoeppe/lpcleandictionary___floating_point_helper_class_for_interactive_simplex_method

comment:8 Changed 6 years ago by mkoeppe

  • Commit changed from 7bdddd4bf4a0b4681f300c156b62afdf832c9ec0 to 5cfc380392e8dc48a774b9292ffe40229cd384b9

Needs more work. The interface has changed and it is now necessary to implement methods row_coefficients, column_coefficients instead of leaving_coefficients, entering_coefficients. Also need to use these new methods in the dictionary() method. And it needs an __eq__ method.

New commits:

​65aafcdMerge remote-tracking branch 'trac/u/zwang/lpcleandictionary___floating_point_helper_class_for_interactive_simplex_method' into test_20203
​259bf2fLPCleanDictionary: Run the testsuite
​5cfc380LPCleanDictionary: Implement row_coefficients instead of leaving_coefficients

comment:9 Changed 6 years ago by mkoeppe

  • Cc pjxiao added

comment:10 Changed 2 years ago by git

  • Commit changed from 5cfc380392e8dc48a774b9292ffe40229cd384b9 to ae348f72c23ea49043f135424da06c2e456cbf8c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​10a063cclean_dictionary.py copied from f45615c
​37e0b3erevise doc tests and implementation to use LPDictionary
​16cb5b9LPCleanDictionary: Run the testsuite
​ae348f7LPCleanDictionary: Implement row_coefficients instead of leaving_coefficients

comment:11 Changed 2 years ago by mkoeppe

Rebased on 9.1.beta1; is already merged into #18804.

comment:12 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-7.2 to sage-9.1

comment:13 follow-up: Changed 2 years ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

This ticket can be closed; it will be developed further in #18804.

comment:14 in reply to: ↑ 13 Changed 2 years ago by vdelecroix

Replying to mkoeppe:

This ticket can be closed; it will be developed further in #18804.

It is not developed further in #18804 which points to ​https://github.com/mkoeppe/sage-numerical-interactive-mip.

comment:15 Changed 2 years ago by mkoeppe

That's correct. It is published and intended to be developed further at ​https://github.com/mkoeppe/sage-numerical-interactive-mip

comment:16 Changed 8 months ago by mjo

  • Reviewers set to Michael Orlitzky
  • Status changed from needs_review to positive_review

Reporter/author says it can be closed. Ok.

comment:17 Changed 8 months ago by mkoeppe

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.