Opened 4 years ago

Closed 3 years ago

#20200 closed enhancement (fixed)

replace polred with polredbest in optimized_representation within number_field.py

Reported by: klui Owned by:
Priority: minor Milestone: sage-8.0
Component: number fields Keywords: polred, polredbest, optimized_representation
Cc: Merged in:
Authors: Kevin Lui Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 8353b7e (Commits) Commit: 8353b7eefe7fce4c48a4ea58a2b6e19e65416c81
Dependencies: Stopgaps:

Description (last modified by klui)

Using polred in K.optimized_representation() computes an optimized representation in all subfields of K. Switching to polredbest will compute it only for K.

Also, polred is deprecated in PARI.

Change History (15)

comment:1 Changed 4 years ago by klui

  • Component changed from PLEASE CHANGE to number fields
  • Description modified (diff)
  • Keywords polred polredbest optimized_representation added
  • Priority changed from major to minor
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 4 years ago by klui

  • Branch set to u/klui/replace_polred_with_polredbest_in_optimized_representation_within_number_field_py

comment:3 follow-up: Changed 4 years ago by jdemeyer

  • Commit set to 6f13df608427f9307874e9175579228396f80ec7

I suggest you also deprecate optimized_subfields() then.


New commits:

6f13df6changed polred to polredbest in optimized_representation in number_field.py

comment:4 in reply to: ↑ 3 Changed 4 years ago by klui

Replying to jdemeyer:

I suggest you also deprecate optimized_subfields() then.


New commits:

6f13df6changed polred to polredbest in optimized_representation in number_field.py

Will do. Should I be starting a new ticket for that? Or should I just include it in this one?

comment:5 Changed 4 years ago by git

  • Commit changed from 6f13df608427f9307874e9175579228396f80ec7 to a4453ca218c5929a6e764c00265855a3e5ab4aa0

Branch pushed to git repo; I updated commit sha1. New commits:

a4453caFixed output and changed doc string of optimized_representation

comment:6 Changed 4 years ago by klui

I think optimized_representation() is ready.

I'll fix optimized_subfields() in a later ticket after figuring out what it's suppose to do. It's giving me more subfields than I expect. (ex. K.<a> = NumberField([x^2+p for p in [2,3]]).absolute_field(); len(K.optimized_subfields()) returns 7 though I expect 5.)

comment:7 Changed 4 years ago by klui

  • Status changed from new to needs_review

comment:8 Changed 4 years ago by klui

  • Authors set to Kevin Lui

comment:9 Changed 4 years ago by klui

  • Status changed from needs_review to needs_work

comment:10 Changed 3 years ago by chapoton

  • Branch changed from u/klui/replace_polred_with_polredbest_in_optimized_representation_within_number_field_py to public/20200
  • Commit changed from a4453ca218c5929a6e764c00265855a3e5ab4aa0 to 5aab8da246a1e3abd91a456cb4313f2ed315da44

rebased on 8.0.b2


New commits:

5aab8daMerge branch 'u/klui/replace_polred_with_polredbest_in_optimized_representation_within_number_field_py' in 8.0.b2

comment:11 Changed 3 years ago by git

  • Commit changed from 5aab8da246a1e3abd91a456cb4313f2ed315da44 to 8353b7eefe7fce4c48a4ea58a2b6e19e65416c81

Branch pushed to git repo; I updated commit sha1. New commits:

8353b7etrac 20200 details

comment:12 Changed 3 years ago by chapoton

  • Milestone changed from sage-7.1 to sage-8.0

comment:13 Changed 3 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:14 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:15 Changed 3 years ago by vbraun

  • Branch changed from public/20200 to 8353b7eefe7fce4c48a4ea58a2b6e19e65416c81
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.