Opened 6 years ago

Closed 6 years ago

#20197 closed defect (fixed)

Allow overriding SAGE_SPKG in build/make/Makefile

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-7.1
Component: build Keywords:
Cc: vbraun Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: f1993fb (Commits, GitHub, GitLab) Commit: f1993fb8b982f112f0c8d4a8edefb2331fd6d623
Dependencies: Stopgaps:

Status badges

Description

The mechanism for ./sage -i -c PKGNAME uses this.

Change History (4)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/allow_overriding_sage_spkg_in_build_make_makefile

comment:2 Changed 6 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to f1993fb8b982f112f0c8d4a8edefb2331fd6d623
  • Status changed from new to needs_review

New commits:

f1993fbAllow overriding SAGE_SPKG in build/make/Makefile

comment:3 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

It does fix the bug

The original implementation is fugly and of doubtful use, why do we need two different ways to check packages? But oh well...

comment:4 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/allow_overriding_sage_spkg_in_build_make_makefile to f1993fb8b982f112f0c8d4a8edefb2331fd6d623
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.