Opened 6 years ago

Closed 6 years ago

#20188 closed enhancement (fixed)

use arb_set_str for RBF(string)

Reported by: fredrik.johansson Owned by:
Priority: major Milestone: sage-7.1
Component: numerical Keywords: arb
Cc: Merged in:
Authors: Fredrik Johansson Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8af0db5 (Commits, GitHub, GitLab) Commit: 8af0db5e09f92bab672267a63e7ee6deab6c3df7
Dependencies: Stopgaps:

Status badges

Description (last modified by fredrik.johansson)

With this patch, it becomes possible to round-trip RBF -> str -> RBF. Also, large exponents are supported.

Change History (6)

comment:1 Changed 6 years ago by fredrik.johansson

  • Branch set to u/fredrik.johansson/use_arb_set_str_for_rbf_string_

comment:2 Changed 6 years ago by git

  • Commit set to 8af0db5e09f92bab672267a63e7ee6deab6c3df7

Branch pushed to git repo; I updated commit sha1. New commits:

8af0db5use arb_set_str to create RealBall from string

comment:3 follow-up: Changed 6 years ago by fredrik.johansson

  • Component changed from PLEASE CHANGE to numerical
  • Description modified (diff)
  • Keywords arb added
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

By the way, the __init__ method is not included on the documentation page. Something that should be changed?

comment:4 in reply to: ↑ 3 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Replying to fredrik.johansson:

By the way, the __init__ method is not included on the documentation page. Something that should be changed?

I believe what you want is

.. automethod:: __init__

See the "private functions" subsection of http://doc.sagemath.org/html/en/developer/coding_basics.html#documentation-strings.

Personally I try to put such documentation at the class level.

Branch LGTM, so if you don't want to fiddle with the documentation, you can set this to a positive review (once you set the author name).

comment:5 Changed 6 years ago by fredrik.johansson

  • Authors set to Fredrik Johansson
  • Status changed from needs_review to positive_review

comment:6 Changed 6 years ago by vbraun

  • Branch changed from u/fredrik.johansson/use_arb_set_str_for_rbf_string_ to 8af0db5e09f92bab672267a63e7ee6deab6c3df7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.