Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20168 closed enhancement (fixed)

small imporvement to projective morphisms

Reported by: bhutz Owned by: bhutz
Priority: minor Milestone: sage-7.2
Component: algebraic geometry Keywords:
Cc: Merged in:
Authors: Ben Hutz Reviewers: Rebecca Lauren Miller
Report Upstream: N/A Work issues:
Branch: 67cda6a (Commits) Commit:
Dependencies: Stopgaps:


This ticket is to take care of a few overlooked minor enhancements for projective morphisms

  • you cannot pass a single point into all_rational_preimages
  • the weil restriction for preperiodic points for number fields, was not also implemented for the rational_periodic_points function
  • neither rational_preperodic_points nor rational_periodic_points accepts the ncpus kwd

Change History (5)

comment:1 Changed 3 years ago by bhutz

  • Branch set to u/bhutz/ticket/20168
  • Commit set to 67cda6a4d0d3bef357efd217af92489597022314
  • Status changed from new to needs_review

New commits:

67cda6a20168: minor improvements to projective morphisms

comment:2 Changed 3 years ago by rlmiller

  • Reviewers set to Rebecca Miller

comment:3 Changed 3 years ago by rlmiller

  • Status changed from needs_review to positive_review

Tested all four minor enhancements. Looks good!

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/bhutz/ticket/20168 to 67cda6a4d0d3bef357efd217af92489597022314
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 Changed 3 years ago by jdemeyer

  • Commit 67cda6a4d0d3bef357efd217af92489597022314 deleted
  • Milestone changed from sage-7.1 to sage-7.2
  • Reviewers changed from Rebecca Miller to Rebecca Lauren Miller
Note: See TracTickets for help on using tickets.