Opened 4 years ago

Closed 4 years ago

#20141 closed defect (fixed)

Cysignals tests fail

Reported by: vbraun Owned by:
Priority: blocker Milestone: sage-7.1
Component: packages: standard Keywords:
Cc: jdemeyer, vdelecroix, fbissey, malb Merged in:
Authors: Jeroen Demeyer Reviewers: Martin Albrecht
Report Upstream: Completely fixed; Fix reported upstream Work issues:
Branch: a1a7c69 (Commits) Commit: a1a7c69e904b5c77bc13070066e8442d9d30cf9a
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Unter certain conditions cysignal tests fail (building with SAGE_CHECK=yes). This is on the buildbot so directories are the same as always. Possibly triggered by a full rebuild:

[...]
python -m doctest src/cysignals/*.pyx
cd example && python setup.py build
sys:1: RuntimeWarning: not adding directory '' to sys.path since it's writable by an untrusted group.
Untrusted users could put files in this directory which might then be imported by your Python code. As a general precaution from similar exploits, you should not execute Python code from this directory
Compiling cysignals_example.pyx because it changed.
[1/1] Cythonizing cysignals_example.pyx
running build
running build_ext
building 'cysignals_example' extension
creating build
creating build/temp.macosx-10.9-x86_64-2.7
gcc -fno-strict-aliasing -I/Users/buildslave-sage/slave/sage_git/build/local/var/tmp/sage/build/python2-2.7.10.p0/include -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -I/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cysignals -I/Users/buildslave-sage/slave/sage_git/build/local/include/python2.7 -c cysignals_example.c -o build/temp.macosx-10.9-x86_64-2.7/cysignals_example.o
creating build/lib.macosx-10.9-x86_64-2.7
gcc -bundle -undefined dynamic_lookup -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib build/temp.macosx-10.9-x86_64-2.7/cysignals_example.o -L/Users/buildslave-sage/slave/sage_git/build/local/lib -o build/lib.macosx-10.9-x86_64-2.7/cysignals_example.so -lpari -Ddummy
**********************************************************************
File "src/cysignals/tests.pyx", line 494, in tests.pyx
Failed example:
    print Popen(['python', '-c', cmd], stdout=PIPE, stderr=PIPE).communicate()[1]  # doctest: +ELLIPSIS
Expected:
    ------------------------------------------------------------------------
    ...
    ------------------------------------------------------------------------
    <BLANKLINE>
Got:
    sys:1: RuntimeWarning: not adding directory '' to sys.path since it's writable by an untrusted group.
    Untrusted users could put files in this directory which might then be imported by your Python code. As a general precaution from similar exploits, you should not execute Python code from this directory
    ------------------------------------------------------------------------
    0   signals.so                          0x0000000108971885 print_backtrace + 37
    ------------------------------------------------------------------------
    <BLANKLINE>
**********************************************************************

PS: as always the cysignals.log is useless since it has many different compilations mashed together and there is no indication where it happened the first time.

Upstream bug: https://github.com/sagemath/cysignals/issues/26

Tarball: https://github.com/sagemath/cysignals/releases/download/1.0.1/cysignals-1.0.1.tar.bz2

Change History (8)

comment:1 Changed 4 years ago by fbissey

Doesn't that message come from one of the patches sage is adding to python? It looks like the folder where the test is run is at fault.

comment:2 Changed 4 years ago by jdemeyer

  • Priority changed from major to blocker
  • Report Upstream changed from N/A to Reported upstream. Developers acknowledge bug.

comment:3 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 4 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Report Upstream changed from Reported upstream. Developers acknowledge bug. to Completely fixed; Fix reported upstream

comment:5 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/cysignals_tests_fail

comment:6 Changed 4 years ago by jdemeyer

  • Commit set to a1a7c69e904b5c77bc13070066e8442d9d30cf9a
  • Status changed from new to needs_review

New commits:

a1a7c69Upgrade to cysignals-1.0.1

comment:7 Changed 4 years ago by malb

  • Reviewers set to Martin Albrecht
  • Status changed from needs_review to positive_review

This looks good to me.

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/cysignals_tests_fail to a1a7c69e904b5c77bc13070066e8442d9d30cf9a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.