Opened 5 years ago

Closed 5 years ago

#20135 closed enhancement (fixed)

Deprecate gsl.pxi and gsl/callback.pyx

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.1
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 7f9272b (Commits) Commit: 7f9272b549ed535e1856f573ddfa455a552db76b
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

These .pxi files should not be used, it's considered better Cython style to use .pxd files.

I'm also deprecating src/sage/gsl/callback.pyx, a very small module which is undocumented and usused.

Change History (7)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/deprecate_gsl_pxi

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 3a58a1726283f89628fee26d536334d65898c6db
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Deprecate gsl.pxi to Deprecate gsl.pxi and gsl/callback.pyx

New commits:

3a58a17Deprecate gsl.pxi and gsl/callback.pyx

comment:3 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good to me. And the bots are happy.

comment:4 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict, wait for next beta..

comment:5 Changed 5 years ago by git

  • Commit changed from 3a58a1726283f89628fee26d536334d65898c6db to 7f9272b549ed535e1856f573ddfa455a552db76b

Branch pushed to git repo; I updated commit sha1. New commits:

7f9272bMerge tag '7.1.beta6' into t/20135/deprecate_gsl_pxi

comment:6 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to positive_review

Fixed trivial merge conflict

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/deprecate_gsl_pxi to 7f9272b549ed535e1856f573ddfa455a552db76b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.