Opened 5 years ago

Closed 5 years ago

#20134 closed defect (fixed)

Upgrade to pynac-0.6.4

Reported by: rws Owned by:
Priority: major Milestone: sage-7.2
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 9cbedc7 (Commits, GitHub, GitLab) Commit: 9cbedc71e156b9758e1226f36d8659d7674677ec
Dependencies: Stopgaps:

Status badges

Description (last modified by rws)

Newest pynac does:

  • fix Re/Im(tanh) (#20098) (R. Stephan)
  • fix positive+integer assumption conflicts (#20132) (A. Thakkar)
  • from GiNaC: [bugfix] fix elusive bug in quo, rem,... (R. Kreckel)
  • from GiNaC: [bugfix] fix sqrfree(poly) for zero polynomials in disguise. (R. Kreckel)
  • sin/cos/tan of numeric: reduce mod 2*pi (#20099) (B. Hackl)
  • more trigonometric simplifications (#20099) (B. Hackl, R. Stephan)
  • always expand function arguments (B. Hackl)
  • exp of numeric: reduce mod 2*pi*I (#20099) (B. Hackl)
  • performance: speed up sin/cos/tan/coth/acoth evaluation (R. Stephan, A. Thakkar)
  • performance: GiNaC functions for coth/sech/csch/acoth/asech/acsch (R. Stephan, A. Thakkar)
  • AUTHORS updated

​https://github.com/pynac/pynac/releases/download/pynac-0.6.4/pynac-0.6.4.tar.bz2

Change History (15)

comment:1 Changed 5 years ago by rws

  • Branch set to u/rws/upgrade_to_pynac_0_6_3

comment:2 Changed 5 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 2fab819852116989ae3676d1a4ff61ecd4adc9b9
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​9db23depackage version / checksum
​7785109coth/acoth BuiltinFunction --> GinacFunction and fixes
​2fab819doctest fixes

comment:3 Changed 5 years ago by behackl

The interface changes on this ticket are relatively straightforward, and I could easily review this. However, I'm not sure whether I should, as I've contributed to the pynac release. What do you think?

comment:4 Changed 5 years ago by rws

In principle I have already had a look at your changes, but I would like to see a third opinion as well.

comment:5 Changed 5 years ago by rws

  • Branch changed from u/rws/upgrade_to_pynac_0_6_3 to u/rws/20134-1

comment:6 Changed 5 years ago by rws

  • Commit changed from 2fab819852116989ae3676d1a4ff61ecd4adc9b9 to f061a28f3229cc85c96a6e9921ea63353c22a304
  • Description modified (diff)
  • Summary changed from Upgrade to pynac-0.6.3 to Upgrade to pynac-0.6.4

New commits:

​fcb8d95a42f798 still fails three in expression.pyx
​bf73f41adapt doctest to have a different arcsech() expression
​65023a5Merge branch 'develop' into for-pynac-0.6.3
​1de52c3expand doctest change
​075374fadd doctest
​6af66d6add doctests for issue 144
​1f61a24sech/csch changes
​f061a28pynac-0.6.4 pkg version/chksum

comment:7 Changed 5 years ago by jdemeyer

The whole point of this doctest is lost: 

        Here arccoth doesn't have 1 in its domain, so we just hold the expression:

            sage: elliptic_e(arccoth(1), x^2*e)
            elliptic_e(arccoth(1), x^2*e)

I would remove the sentence "Here arccoth doesn't have 1 in its domain, so we just hold the expression:"

comment:8 Changed 5 years ago by rws

  • Description modified (diff)

comment:9 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Unless I'm missing something, this doctest looks gone: 

            sage: diff(asech(x), x)
            -1/((x + 1)*x*sqrt(-(x - 1)/(x + 1)))

comment:10 Changed 5 years ago by jdemeyer

Don't forget 7

Last edited 5 years ago by jdemeyer (previous) (diff)

comment:11 Changed 5 years ago by git

  • Commit changed from f061a28f3229cc85c96a6e9921ea63353c22a304 to 0791a6178c020a6f0d7bc388d95ea20564393995

Branch pushed to git repo; I updated commit sha1. New commits:

​0791a61Merge branch 'develop' into t/20134/20134-1

comment:12 Changed 5 years ago by git

  • Commit changed from 0791a6178c020a6f0d7bc388d95ea20564393995 to 9cbedc71e156b9758e1226f36d8659d7674677ec

Branch pushed to git repo; I updated commit sha1. New commits:

​9cbedc720134: fix/add doctests

comment:13 Changed 5 years ago by rws

  • Milestone changed from sage-7.1 to sage-7.2
  • Status changed from needs_work to needs_review

comment:14 Changed 5 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:15 Changed 5 years ago by vbraun

  • Branch changed from u/rws/20134-1 to 9cbedc71e156b9758e1226f36d8659d7674677ec
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.