Opened 6 years ago

Closed 5 years ago

#20124 closed enhancement (fixed)

A new structure for extended codes

Reported by: dlucas Owned by:
Priority: major Milestone: sage-7.3
Component: coding theory Keywords:
Cc: Merged in:
Authors: David Lucas Reviewers: Julien Lavauzelle
Report Upstream: N/A Work issues:
Branch: e54ef7f (Commits, GitHub, GitLab) Commit: e54ef7ffc0002e89c667ef846766563adf61028e
Dependencies: #19653 Stopgaps:

Status badges

Description (last modified by dlucas)

This ticket proposes a new implementation for extended codes.

It contains:

  • a new code class, ExtendedCode
  • a dedicated encoder to compute the generator matrix of an Extended Code.
  • a dedicated decoder which uses the original code to correct errors

Change History (15)

comment:1 Changed 6 years ago by dlucas

  • Description modified (diff)

comment:2 Changed 6 years ago by dlucas

  • Branch set to u/dlucas/extended_codes

comment:3 Changed 6 years ago by dlucas

  • Authors set to David Lucas
  • Commit set to 561ccd416cdffb6b78adc9ac03ce06f58cc883b9
  • Dependencies set to #19653
  • Status changed from new to needs_review

I pushed the branch, this is now open for review.


Last 10 new commits:

c4ca177Better doctests for Error-Erasure decoder, added sanity check on decode_to_messaage's input
a074cb8Changed my helper methods into private methods
6ad583fFixed bug in KeyEquation decoder's decode_to_code, added sanity checks, enhanced doctests
fca099eAdded new sanity check on the output of BW and Gao decoder
57dbfbfRewrote random_element method
7953d60Proper sanity checks for output of decode_to_* methods
8673ac5Optimized a bit polynomial division in Gao and BW
e1b6b09Merged now postive reviewed #19666 and fixed conflicts
f66aa6cMerged branch related to GRS decoders
561ccd4Added random_element method, fixed decoder so it handles properly list-decoders

comment:4 Changed 5 years ago by jsrn

Shouldn't LinearCode.extended_code use this?

comment:5 Changed 5 years ago by git

  • Commit changed from 561ccd416cdffb6b78adc9ac03ce06f58cc883b9 to 8b81ae35da52601120183a71a5811aacc24bf230

Branch pushed to git repo; I updated commit sha1. New commits:

e0f6692Merge branch 'develop' into extended_codes
8b81ae3extended_code() method over linear codes now returns an ExtendedCode object. Fixed related doctests.

comment:6 Changed 5 years ago by dlucas

Definitely. And it does now!

David

comment:7 Changed 5 years ago by git

  • Commit changed from 8b81ae35da52601120183a71a5811aacc24bf230 to 57ebe0c7ba6590f04910ba036681c10a0a75e2ad

Branch pushed to git repo; I updated commit sha1. New commits:

57ebe0cUpdated to 7.3b1 and fixed conflicts

comment:8 Changed 5 years ago by dlucas

  • Milestone changed from sage-7.1 to sage-7.3

Hello,

I fixed conflicts that arose after the update to Sage 7.3beta1. This is still open for review.

David

comment:9 Changed 5 years ago by jlavauzelle

  • Branch changed from u/dlucas/extended_codes to u/jlavauzelle/extended_codes

comment:10 Changed 5 years ago by jlavauzelle

  • Commit changed from 57ebe0c7ba6590f04910ba036681c10a0a75e2ad to 784975a9095f445c8bbf427770e599103b7cf8c8
  • Reviewers set to Julien Lavauzelle

Hi David,

I fixed some stuff in the doc, add sanity check and modified the decoding_radius method. Green light for the rest of the code.

Best,

Julien


New commits:

594e46cMerge branch 'u/dlucas/extended_codes' of git://trac.sagemath.org/sage into u/jlavauzelle/extended_codes
0289f90Merge branch 'u/dlucas/extended_codes' of git://trac.sagemath.org/sage into u/jlavauzelle/extended_codes
d05bfc4Fix the documentation.
784975aAdded sanity checks. Fixed decoding_radius method arguments.

comment:11 Changed 5 years ago by dlucas

  • Branch changed from u/jlavauzelle/extended_codes to u/dlucas/extended_codes

comment:12 Changed 5 years ago by dlucas

  • Commit changed from 784975a9095f445c8bbf427770e599103b7cf8c8 to 04e48aea6c254bb6ef32147b6bfd641570f44a30

Hello,

There was a few broken doctests, which I fixed. I agree with the changes you made on the ticket, and if you're ok with my fix, you can set this to positive_review.

Best,

David


New commits:

04e48aeFixed broken doctests

comment:13 Changed 5 years ago by jlavauzelle

  • Branch changed from u/dlucas/extended_codes to u/jlavauzelle/extended_codes

comment:14 Changed 5 years ago by jlavauzelle

  • Commit changed from 04e48aea6c254bb6ef32147b6bfd641570f44a30 to e54ef7ffc0002e89c667ef846766563adf61028e
  • Status changed from needs_review to positive_review

Hi David,

I agree with your fixes. Tests passed, doc is okay. I give the positive review.

Best,

Julien


New commits:

e54ef7fMerge branch 'develop' into t/20124/extended_codes

comment:15 Changed 5 years ago by vbraun

  • Branch changed from u/jlavauzelle/extended_codes to e54ef7ffc0002e89c667ef846766563adf61028e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.