Opened 5 years ago

Closed 5 years ago

#20120 closed enhancement (fixed)

Python script to uncompress spkg files

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-7.1
Component: build Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 4792571 (Commits) Commit: 47925716f1e5030e462750e29b6b66c74c41621f
Dependencies: Stopgaps:

Description

Replace the uncompressing code in the bash script build/bin/sage-spkg with a Python script.

Change History (6)

comment:1 Changed 5 years ago by jhpalmieri

  • Status changed from new to needs_review

comment:2 Changed 5 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/uncompress

comment:3 follow-up: Changed 5 years ago by jdemeyer

  • Commit set to 47925716f1e5030e462750e29b6b66c74c41621f

Did you try make distclean; make with this branch?


New commits:

4792571Python script to uncompress spkg file

comment:4 in reply to: ↑ 3 Changed 5 years ago by jhpalmieri

Replying to jdemeyer:

Did you try make distclean; make with this branch?

Yes, it worked for me on OS X. I haven't tried other platforms. (I don't know if Python's tarfile and zipfile modules have any variation depending on platform.)

comment:5 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jhpalmieri/uncompress to 47925716f1e5030e462750e29b6b66c74c41621f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.