Opened 7 years ago

Closed 7 years ago

#20113 closed enhancement (fixed)

Simplify LinearCode.zero method

Reported by: David Lucas Owned by:
Priority: major Milestone: sage-7.1
Component: coding theory Keywords: beginner
Cc: Merged in:
Authors: David Lucas Reviewers: Arpit Merchant
Report Upstream: N/A Work issues:
Branch: 806642e (Commits, GitHub, GitLab) Commit: 806642e6eb32d0ad146606512e80351e0f481b3f
Dependencies: Stopgaps:

Status badges

Description

Implementation of method zero from AbstractLinearCode can be improved by just returning the zero vector of the ambient space of the code.

Change History (6)

comment:1 Changed 7 years ago by David Lucas

Branch: u/dlucas/zero_of_codes

comment:2 Changed 7 years ago by David Lucas

Authors: David Lucas
Commit: 806642e6eb32d0ad146606512e80351e0f481b3f
Keywords: beginner added; "beginner" removed
Status: newneeds_review

Pushed the fix, it's now open for review.


New commits:

806642eRewrote zero method for codes

comment:3 Changed 7 years ago by Arpit Merchant

Status: needs_reviewpositive_review

I agree with the changes, the tests pass. I'm giving this a positive review.

comment:4 Changed 7 years ago by Travis Scrimshaw

You will need to put your real name as the reviewer.

comment:5 Changed 7 years ago by Arpit Merchant

Reviewers: Arpit Merchant

comment:6 Changed 7 years ago by Volker Braun

Branch: u/dlucas/zero_of_codes806642e6eb32d0ad146606512e80351e0f481b3f
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.