Opened 5 years ago
Closed 5 years ago
#20113 closed enhancement (fixed)
Simplify LinearCode.zero method
Reported by: | dlucas | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.1 |
Component: | coding theory | Keywords: | beginner |
Cc: | Merged in: | ||
Authors: | David Lucas | Reviewers: | Arpit Merchant |
Report Upstream: | N/A | Work issues: | |
Branch: | 806642e (Commits, GitHub, GitLab) | Commit: | 806642e6eb32d0ad146606512e80351e0f481b3f |
Dependencies: | Stopgaps: |
Description
Implementation of method zero
from AbstractLinearCode
can be improved by just returning the zero vector of the ambient space of the code.
Change History (6)
comment:1 Changed 5 years ago by
- Branch set to u/dlucas/zero_of_codes
comment:2 Changed 5 years ago by
- Commit set to 806642e6eb32d0ad146606512e80351e0f481b3f
- Keywords beginner added; "beginner" removed
- Status changed from new to needs_review
comment:3 Changed 5 years ago by
- Status changed from needs_review to positive_review
I agree with the changes, the tests pass. I'm giving this a positive review.
comment:4 Changed 5 years ago by
You will need to put your real name as the reviewer.
comment:5 Changed 5 years ago by
- Reviewers set to Arpit Merchant
comment:6 Changed 5 years ago by
- Branch changed from u/dlucas/zero_of_codes to 806642e6eb32d0ad146606512e80351e0f481b3f
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Pushed the fix, it's now open for review.
New commits:
Rewrote zero method for codes