#20109 closed enhancement (fixed)
Add pictures to plot3d.py
Reported by:  jhonrubia6  Owned by:  

Priority:  major  Milestone:  sage7.2 
Component:  documentation  Keywords:  pictures, plot 
Cc:  egourgoulhon  Merged in:  
Authors:  Javier Honrubia González  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  2962cd9 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Description (last modified by )
Patch to add pictures generated using .. PLOT:: to the plot3d.py file
Change History (18)
comment:1 Changed 6 years ago by
 Branch set to t/20109/add_pictures_to_plot3d_py
 Component changed from PLEASE CHANGE to documentation
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 6 years ago by
 Branch t/20109/add_pictures_to_plot3d_py deleted
comment:3 Changed 6 years ago by
 Branch set to u/jhonrubia6/add_pictures_to_plot3d_py
comment:4 Changed 6 years ago by
 Commit set to a46d881f7dbe7b17efa07ce035a10e6a4df282b8
 Description modified (diff)
 Keywords pictures plot added
 Status changed from new to needs_review
comment:5 Changed 6 years ago by
 Milestone changed from sage7.1 to sage7.2
comment:6 Changed 6 years ago by
 Cc egourgoulhon added
comment:7 Changed 6 years ago by
 Commit changed from a46d881f7dbe7b17efa07ce035a10e6a4df282b8 to 230bf0c61b88a88b0f045127c9a290be9082e964
Branch pushed to git repo; I updated commit sha1. New commits:
230bf0c  Added some doctest to the plot() methods in parametric_surface.pyx and base.pyx

comment:8 followup: ↓ 9 Changed 6 years ago by
what is the purpose of these tautological def plot(self):
? To support PLOT::
blocks in docstrings?
comment:9 in reply to: ↑ 8 Changed 6 years ago by
comment:10 followup: ↓ 11 Changed 6 years ago by
Could you add to docstrings of these two plot()
functions something like needed to support PLOT in doctrings
?
Otherwise it's quite baffling to see...
comment:11 in reply to: ↑ 10 Changed 6 years ago by
Replying to dimpase:
Could you add to docstrings of these two
plot()
functions something likeneeded to support PLOT in doctrings
?Otherwise it's quite baffling to see...
sure, it does make sense. I will do it in my next commit
comment:12 Changed 6 years ago by
 Commit changed from 230bf0c61b88a88b0f045127c9a290be9082e964 to 2962cd943e17d8d2b10ab4efee722178b4d0467f
Branch pushed to git repo; I updated commit sha1. New commits:
2962cd9  Added some comments clarifying the need of plot() methods.

comment:13 followup: ↓ 14 Changed 6 years ago by
Where exactly in the docs should one see these new figures?
I don't get any pictures in reference/plot3d/sage/plot/plot3d/parametric_plot3d.html
comment:14 in reply to: ↑ 13 ; followup: ↓ 15 Changed 6 years ago by
Replying to dimpase:
Where exactly in the docs should one see these new figures?
I don't get any pictures in reference/plot3d/sage/plot/plot3d/parametric_plot3d.html
No, the pictures are in reference/plot3d/sage/plot/plot3d/plot3d.html
comment:15 in reply to: ↑ 14 Changed 6 years ago by
 Status changed from needs_review to positive_review
Replying to jhonrubia6:
Replying to dimpase:
Where exactly in the docs should one see these new figures?
I don't get any pictures in reference/plot3d/sage/plot/plot3d/parametric_plot3d.html
No, the pictures are in reference/plot3d/sage/plot/plot3d/plot3d.html
wow, cool pictures!!!
comment:16 Changed 6 years ago by
 Reviewers set to Dima Pasechnik
comment:17 Changed 6 years ago by
 Branch changed from u/jhonrubia6/add_pictures_to_plot3d_py to 2962cd943e17d8d2b10ab4efee722178b4d0467f
 Resolution set to fixed
 Status changed from positive_review to closed
comment:18 Changed 6 years ago by
 Commit 2962cd943e17d8d2b10ab4efee722178b4d0467f deleted
New commits:
Added pictures to plot3d.py and auxiliar plot() methods in base.pyx and parametric_surface.pyx