#20079 closed enhancement (fixed)

Chebyshev Polynomial Generator

Reported by: eisnerj Owned by: Joseph Eisner
Priority: minor Milestone: sage-7.3
Component: algebraic geometry Keywords:
Cc: rlmiller Merged in:
Authors: Joseph Eisner, Ben Hutz Reviewers: Kiran Kedlaya, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 8c8e9da (Commits) Commit: 8c8e9dae72fb8dff984cda762817faad32611237
Dependencies: Stopgaps:

Description

Implement functionality to generate Chebyshev polynomials of a given kind and degree as: proper polynomials, as polynomials in affine space, and as projective morphisms.

Change History (13)

comment:1 Changed 19 months ago by eisnerj

  • Priority changed from major to minor

comment:2 Changed 18 months ago by kedlaya

Do you mean something other than the usual Chebyshev polynomials of the first/second kind? Those are generated by chebyshev_T and chebyshev_U.

comment:3 Changed 17 months ago by bhutz

  • Branch set to u/bhutz/chebyshev_polynomial_generator

comment:4 Changed 17 months ago by bhutz

  • Authors set to Joseph Eisner, Ben Hutz
  • Cc rlmiller added
  • Commit set to 7d495b90ba282ba2bf70d4dfad60b8600e5cd912
  • Status changed from new to needs_review

also fixed a typo in the generic/morphism.py documentation


New commits:

7d495b920079: chebyshev polynomials for affine and projective spaces

comment:5 Changed 17 months ago by kedlaya

  • Status changed from needs_review to needs_work

Typos in the docstrings: for chebyshev_polynomial (both occurrences), "ofrecursively" and "Chebyhshev". More significantly, could you add doctests (in both functions) for the TypeError when the projective space is of the wrong dimension?

comment:6 Changed 17 months ago by git

  • Commit changed from 7d495b90ba282ba2bf70d4dfad60b8600e5cd912 to a69402d226323d4bb8980b3a4ea001255c9c5763

Branch pushed to git repo; I updated commit sha1. New commits:

a69402d20079: fixed typo, added doc test

comment:7 Changed 17 months ago by bhutz

  • Status changed from needs_work to needs_review

Thanks for catching those typos. Doc test added.

comment:8 Changed 17 months ago by kedlaya

  • Reviewers set to Kiran Kedlaya
  • Status changed from needs_review to positive_review

Looks fine to me, and passes make ptestlong for me. Positive review.

comment:9 Changed 17 months ago by chapoton

  • Milestone changed from sage-7.1 to sage-7.3
  • Status changed from positive_review to needs_work

doc does not build, see patchbot report

+[schemes  ] /home/patchbot/sage-patchbot/local/lib/python2.7/site-packages/sage/schemes/affine/affine_space.py:docstring of sage.schemes.affine.affine_space.AffineSpace_generic.chebyshev_polynomial:14: WARNING: Bullet list ends without a blank line; unexpected unindent.
+[schemes  ] /home/patchbot/sage-patchbot/local/lib/python2.7/site-packages/sage/schemes/projective/projective_space.py:docstring of sage.schemes.projective.projective_space.ProjectiveSpace_ring.chebyshev_polynomial:14: WARNING: Bullet list ends without a blank line; unexpected unindent.
+Error building the documentation.

comment:10 Changed 17 months ago by git

  • Commit changed from a69402d226323d4bb8980b3a4ea001255c9c5763 to 8c8e9dae72fb8dff984cda762817faad32611237

Branch pushed to git repo; I updated commit sha1. New commits:

8c8e9da20079: fix doc issue

comment:11 Changed 17 months ago by bhutz

  • Status changed from needs_work to needs_review

fixed those two lines

comment:12 Changed 17 months ago by chapoton

  • Reviewers changed from Kiran Kedlaya to Kiran Kedlaya, Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, thanks

comment:13 Changed 16 months ago by vbraun

  • Branch changed from u/bhutz/chebyshev_polynomial_generator to 8c8e9dae72fb8dff984cda762817faad32611237
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.