Opened 6 years ago
Last modified 6 years ago
#20074 closed enhancement
QQbar cleaning 2 — at Version 1
Reported by: | vdelecroix | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.1 |
Component: | number fields | Keywords: | |
Cc: | Merged in: | ||
Authors: | Vincent Delecroix | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/vdelecroix/20074 (Commits, GitHub, GitLab) | Commit: | 9264ff161e50900ce17ca62393d70b8abc4b4bb6 |
Dependencies: | #19954 | Stopgaps: |
Description (last modified by )
We further simplify QQbar code by:
- using python operator to indentify binary operators instead of strings. In other words we replace
'+'
byoperator.add
,'-'
byoperator.sub
, etc - writing only one function
binop
instead ofaddsub
andmuldiv
. - removing the method
kind
of descriptors and instead use the class themselves for dispatching - detect unions earlier in the code to avoid constructing
ANBinaryExpr
follow up: #19955
Change History (1)
comment:1 Changed 6 years ago by
- Branch set to u/vdelecroix/20074
- Commit set to 9264ff161e50900ce17ca62393d70b8abc4b4bb6
- Description modified (diff)
- Status changed from new to needs_review
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
Trac 19954: fix doctests
Trac 19954: fix sage_input doctests
Trac 19954: move the 34-gon as a doctest
Trac 19954: merge 7.1.beta1
Trac 19954: fix doctests
Trac 19954: doctest independent of execution order
Trac 19954: typo in documentation
Trac 19954: documentation
Trac 19954: remove useless "gaussian" functions
Trac 20074: qqbar cleaning