Opened 6 years ago
Closed 5 years ago
#20073 closed defect (fixed)
padic extensions with nonmonic polynomials
Reported by:  roed  Owned by:  

Priority:  major  Milestone:  sage7.1 
Component:  padics  Keywords:  sd87 
Cc:  Merged in:  
Authors:  Adele Bourgeois  Reviewers:  GaYee Park 
Report Upstream:  N/A  Work issues:  
Branch:  48be601 (Commits, GitHub, GitLab)  Commit:  48be601fe35d7d56ec6cbbb6d21bb6921230b7eb 
Dependencies:  Stopgaps: 
Description
sage: A = Qp(3,5) sage: Po.<X> = A[] sage: f = Po([3,0,1]) sage: K.<a> = A.ext(f) Traceback (most recent call last): ... UnboundLocalError: local variable 'preseed' referenced before assignment
Change History (13)
comment:1 Changed 6 years ago by
 Branch set to u/asteele/ticket/20073
comment:2 Changed 6 years ago by
 Commit set to 7f966970ce066669c13ec27ef5d6c13eaf6441dd
 Status changed from new to needs_review
comment:3 Changed 6 years ago by
 Status changed from needs_review to needs_work
So, whenever you fix a bug you also need to add doctests to show that the bug has been fixed. In this case, try creating some extensions defined by nonmonic polynomials and playing around with them. Do they behave as you would want?
comment:4 Changed 6 years ago by
 Commit changed from 7f966970ce066669c13ec27ef5d6c13eaf6441dd to bbb7268c1692a0068a9d4bd5ae7624eadf321454
Branch pushed to git repo; I updated commit sha1. New commits:
bbb7268  added doctests

comment:5 Changed 6 years ago by
Your branch doesn't merge against develop. I think the following will work, if executed from within the sage folder:
~/sage$ git fetch trac develop:develop ~/sage$ git pull develop
comment:6 Changed 6 years ago by
 Commit changed from bbb7268c1692a0068a9d4bd5ae7624eadf321454 to 8081eab7fac81a3cef7d40133937bc2ca01baa38
comment:7 Changed 6 years ago by
Thanks for the help! Should merge cleanly now.
comment:8 Changed 6 years ago by
Cool. You should also add some tests showing that the resulting extensions have the right defining polynomial.
comment:9 Changed 5 years ago by
 Keywords sd87 added
comment:10 Changed 5 years ago by
 Branch changed from u/asteele/ticket/20073 to u/abourgeois/ticket/20073
comment:11 Changed 5 years ago by
 Commit changed from 8081eab7fac81a3cef7d40133937bc2ca01baa38 to 48be601fe35d7d56ec6cbbb6d21bb6921230b7eb
 Status changed from needs_work to needs_review
comment:12 Changed 5 years ago by
 Reviewers set to GaYee Park
 Status changed from needs_review to positive_review
All test passed
comment:13 Changed 5 years ago by
 Branch changed from u/abourgeois/ticket/20073 to 48be601fe35d7d56ec6cbbb6d21bb6921230b7eb
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Fixed typo with variable assignment