Opened 4 years ago

Last modified 8 months ago

#20066 needs_work defect

asymptotic expansion generators: fix precision parameter

Reported by: behackl Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords:
Cc: cheuberg, dkrenn Merged in:
Authors: Benjamin Hackl Reviewers:
Report Upstream: N/A Work issues:
Branch: u/behackl/asy/generators/precision-fix (Commits) Commit: e91eb655ffd3f6a11e6826f17e101b4512ae0816
Dependencies: Stopgaps:

Description

this should not happen:

sage: asymptotic_expansions.Binomial_kn_over_n('n', 2)
Traceback (most recent call last):
...
TypeError: unsupported operand type(s) for -: 'NoneType' and 'int'

and

sage: asymptotic_expansions.Stirling('n')
Traceback (most recent call last):
...
ValueError: precision must be at least 3

Change History (4)

comment:1 Changed 4 years ago by behackl

  • Authors set to Benjamin Hackl
  • Branch set to u/behackl/asy/generators/precision-fix
  • Commit set to e91eb655ffd3f6a11e6826f17e101b4512ae0816
  • Status changed from new to needs_review

For the Stirling generator, I couldn't get something along the lines of

if precision is not None and precision < 3:
    raise ...

to work: while it works in Sage on the console, the doctest-framework wasn't happy with my tests. Suggestions are welcome.


Last 10 new commits:

197fe43Trac #20053: Merge #20056
bbbfab9Trac #20053: Also rename method here
071a595Trac #20053: Refactor: new method AsymptoticRing._singularity_analysis_
2b2e94dTrac #20053: minor cleanup in coefficients_of_generating_function
7f8c745Trac #20053: add warning to coefficients_of_generating_function
7acc487Trac #20053: Merge branch #19540 to resolve merge conflict
1949e30Merge branch 'asy/allow-singular-expansion' into t/17601/public/asy/trunk
e8b7f0ffix precision for stirling generator
3ba6258fix precision for binomial-generators
e91eb65add doctests

comment:2 Changed 4 years ago by behackl

I've mistakenly started this from asy/trunk, this has to be rebased to something else.

comment:3 Changed 3 years ago by cheuberg

  • Status changed from needs_review to needs_work

does not merge (cf. patchbot).

comment:4 Changed 8 months ago by dkrenn

Ping ;)

Note: See TracTickets for help on using tickets.