#20059 closed defect (fixed)
minimal periodic points code improvement
Reported by: | bhutz | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | sage-7.1 |
Component: | algebraic geometry | Keywords: | |
Cc: | gjorgenson | Merged in: | |
Authors: | Ben Hutz | Reviewers: | Rebecca Lauren Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | 3c9adc3 (Commits) | Commit: | |
Dependencies: | Stopgaps: |
Description
In projective morphism the code block for minimal periodic points around line 3003
if not minimal: return points else: rem_indices = [] for i in range(len(points)-1,-1,-1): # iterate points to check if minimal P = points[i] for j in range(1,n): P = self(P) if P == points[i]: points.pop(i) break return points
has an unused list and could use some additional comments to explain what this is doing.
Change History (7)
comment:1 Changed 2 years ago by
- Branch set to u/bhutz/ticket/20059
comment:2 Changed 2 years ago by
- Commit set to 3c9adc373b56653c6ec54c30df985974359e1b1d
- Status changed from new to needs_review
comment:3 Changed 2 years ago by
- Reviewers set to Rebecca Miller
comment:4 Changed 2 years ago by
- Status changed from needs_review to positive_review
Looks good to me.
comment:5 Changed 2 years ago by
- Branch changed from u/bhutz/ticket/20059 to 3c9adc373b56653c6ec54c30df985974359e1b1d
- Resolution set to fixed
- Status changed from positive_review to closed
comment:6 Changed 2 years ago by
- Commit 3c9adc373b56653c6ec54c30df985974359e1b1d deleted
What do you prefer: "Rebecca Lauren Miller" or "Rebecca Miller"?
comment:7 Changed 2 years ago by
- Reviewers changed from Rebecca Miller to Rebecca Lauren Miller
Note: See
TracTickets for help on using
tickets.
In addition to adding the documentation to the minimal section I made three improvements to the function
New commits:
20059: improvement to projective periodic_points function