Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20059 closed defect (fixed)

minimal periodic points code improvement

Reported by: bhutz Owned by:
Priority: trivial Milestone: sage-7.1
Component: algebraic geometry Keywords:
Cc: gjorgenson Merged in:
Authors: Ben Hutz Reviewers: Rebecca Lauren Miller
Report Upstream: N/A Work issues:
Branch: 3c9adc3 (Commits) Commit:
Dependencies: Stopgaps:

Description

In projective morphism the code block for minimal periodic points around line 3003

        if not minimal:
            return points
        else:
            rem_indices = []
            for i in range(len(points)-1,-1,-1):
                # iterate points to check if minimal
                P = points[i]
                for j in range(1,n):
                    P = self(P)
                    if P == points[i]:
                        points.pop(i)
                        break
            return points

has an unused list and could use some additional comments to explain what this is doing.

Change History (7)

comment:1 Changed 3 years ago by bhutz

  • Branch set to u/bhutz/ticket/20059

comment:2 Changed 3 years ago by bhutz

  • Authors set to Ben Hutz
  • Commit set to 3c9adc373b56653c6ec54c30df985974359e1b1d
  • Status changed from new to needs_review

In addition to adding the documentation to the minimal section I made three improvements to the function

  • allowed the user to pass in a ring where the points should be defined
  • extended the functionality to include finite fields
  • allowed the user to choose the method used

New commits:

3c9adc320059: improvement to projective periodic_points function

comment:3 Changed 3 years ago by rlmiller

  • Reviewers set to Rebecca Miller

comment:4 Changed 3 years ago by rlmiller

  • Status changed from needs_review to positive_review

Looks good to me.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/bhutz/ticket/20059 to 3c9adc373b56653c6ec54c30df985974359e1b1d
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 3 years ago by jdemeyer

  • Commit 3c9adc373b56653c6ec54c30df985974359e1b1d deleted

What do you prefer: "Rebecca Lauren Miller" or "Rebecca Miller"?

comment:7 Changed 3 years ago by rlmiller

  • Reviewers changed from Rebecca Miller to Rebecca Lauren Miller
Note: See TracTickets for help on using tickets.