Opened 4 years ago

Closed 4 years ago

#20056 closed defect (fixed)

Rename AsymptoticRing.singularity_analysis to coefficients_of_generating_function

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords:
Cc: dkrenn, behackl Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 40b6e2e (Commits) Commit: 40b6e2ee0e5b74a862c302ed684f44ab1ca85870
Dependencies: #20040 Stopgaps:

Description (last modified by cheuberg)

Rename AsymptoticRing.singularity_analysis to AsymptoticRing.coefficients_of_generating_function in order to describe what the method does instead of how it does it.

Furthermore, in #20053, we will introduce a method AsymptoticExpansion.singularity_analysis and it seems to be better to have different names for related, but not identical functionalities.

Change History (5)

comment:1 Changed 4 years ago by cheuberg

  • Branch set to u/cheuberg/asy/rename-singularity-analysis

comment:2 Changed 4 years ago by cheuberg

  • Commit set to 40b6e2ee0e5b74a862c302ed684f44ab1ca85870
  • Dependencies set to #20040
  • Description modified (diff)
  • Status changed from new to needs_review

Last 10 new commits:

902c182Trac #20040: Merge #19944
866a9e3Trac #20040: exchange order of parameters var and zeta in _singularity_analysis_
c79a6f7Trac #19944: exchange zeta and var in docstrings
d0f5e94Trac #20040: Merge #19944
27a8605Merge branch 'u/cheuberg/asy/singularity-analysis-method-log' of git://trac.sagemath.org/sage into t/20040/asy/singularity-analysis-method-log
452c43bTrac #19944: _singularity_analysis_ methods: more precise documentation
4cb5934Trac #20040: Merge #19944
8455dc2Trac #20040: _singularity_analysis_ methods: more precise documentation
8bb9046Trac #20040: added myself to AUTHORS
40b6e2eTrac #20056: Rename AsymptoticRing.singularity_analysis to coefficients_generating_function

comment:3 Changed 4 years ago by dkrenn

  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

LGTM

comment:4 Changed 4 years ago by cheuberg

  • Description modified (diff)
  • Summary changed from Rename AsymptoticRing.singularity_analysis to coefficients_generating_function to Rename AsymptoticRing.singularity_analysis to coefficients_of_generating_function

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/asy/rename-singularity-analysis to 40b6e2ee0e5b74a862c302ed684f44ab1ca85870
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.