Opened 4 years ago

Closed 4 years ago

#20049 closed defect (fixed)

singularity in formula in docstring of SingularityAnalysis-generator

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords: singularity analysis
Cc: behackl, cheuberg Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: d3b48c7 (Commits) Commit: d3b48c7070f8b3a7e0851c5ed6d62e5d95472a0a
Dependencies: #19969 Stopgaps:

Description

        .. MATH::

            [z^n] \left(\frac{1}{1-z}\right)^\alpha
            \left(\frac{1}{z} \log \frac{1}{1-z}\right)^\beta
            \left(\frac{1}{z} \log
            \left(\frac{1}{z} \log \frac{1}{1-z}\right)\right)^\delta.

does not depend on the singularity \zeta, which is incorrect (and not mentioned at all).

Change History (7)

comment:1 follow-ups: Changed 4 years ago by dkrenn

We can either change to

        .. MATH::

            [z^n] \left(\frac{1}{1-z/\zeta}\right)^\alpha
            \left(\frac{1}{z/\zeta} \log \frac{1}{1-z/\zeta}\right)^\beta
            \left(\frac{1}{z/\zeta} \log
            \left(\frac{1}{z/\zeta} \log \frac{1}{1-z/\zeta}\right)\right)^\delta.

or prepend a (1/\zeta)^n to the formula.

comment:2 Changed 4 years ago by dkrenn

  • Branch set to u/dkrenn/asy/SA-generator-log

comment:3 in reply to: ↑ 1 Changed 4 years ago by dkrenn

  • Branch u/dkrenn/asy/SA-generator-log deleted
Last edited 4 years ago by dkrenn (previous) (diff)

comment:4 Changed 4 years ago by dkrenn

  • Branch set to u/dkrenn/zeta-in-GF

comment:5 in reply to: ↑ 1 Changed 4 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Commit set to d3b48c7070f8b3a7e0851c5ed6d62e5d95472a0a
  • Status changed from new to needs_review

Replying to dkrenn:

We can either change to

        .. MATH::

            [z^n] \left(\frac{1}{1-z/\zeta}\right)^\alpha
            \left(\frac{1}{z/\zeta} \log \frac{1}{1-z/\zeta}\right)^\beta
            \left(\frac{1}{z/\zeta} \log
            \left(\frac{1}{z/\zeta} \log \frac{1}{1-z/\zeta}\right)\right)^\delta.

or prepend a (1/\zeta)^n to the formula.

The first choice does not look that bad, so I've prepared a patch.


Last 10 new commits:

c2f30f5move code of NotImplementedOZero to avoid merge-conflicts
ebac5c2Trac #20043: add additional doctest to check parent
33f675dMerge branch 'u/dkrenn/asy/one-times-zero' of trac.sagemath.org:sage into t/19969/asy/SA-generator-log
98e1fc7Trac #20043: make error message more precise and flexibel
99d7292Merge branch 't/20043/asy/one-times-zero' into t/19969/asy/SA-generator-log
dd7dabfTrac #19969: fix doctest
617e5bfTrac #19969: rewrite output of doctest so that comparison with Formula in Flajolet-Sedgewick is easier
456d8c3Trac #19969: correct whitespaces
b540598Trac #19969: add an additional doctest
d3b48c7Trac #20049: \zeta in GF in SingularityAnalysis-generator

comment:6 Changed 4 years ago by cheuberg

  • Dependencies set to #19969
  • Keywords singularity analysis added
  • Reviewers set to Clemens Heuberger
  • Status changed from needs_review to positive_review

LGTM

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/dkrenn/zeta-in-GF to d3b48c7070f8b3a7e0851c5ed6d62e5d95472a0a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.