Opened 4 years ago
Closed 4 years ago
#20049 closed defect (fixed)
singularity in formula in docstring of SingularityAnalysisgenerator
Reported by:  dkrenn  Owned by:  

Priority:  major  Milestone:  sage7.1 
Component:  asymptotic expansions  Keywords:  singularity analysis 
Cc:  behackl, cheuberg  Merged in:  
Authors:  Daniel Krenn  Reviewers:  Clemens Heuberger 
Report Upstream:  N/A  Work issues:  
Branch:  d3b48c7 (Commits)  Commit:  d3b48c7070f8b3a7e0851c5ed6d62e5d95472a0a 
Dependencies:  #19969  Stopgaps: 
Description
.. MATH:: [z^n] \left(\frac{1}{1z}\right)^\alpha \left(\frac{1}{z} \log \frac{1}{1z}\right)^\beta \left(\frac{1}{z} \log \left(\frac{1}{z} \log \frac{1}{1z}\right)\right)^\delta.
does not depend on the singularity \zeta
, which is incorrect (and not mentioned at all).
Change History (7)
comment:1 followups: ↓ 3 ↓ 5 Changed 4 years ago by
comment:2 Changed 4 years ago by
 Branch set to u/dkrenn/asy/SAgeneratorlog
comment:3 in reply to: ↑ 1 Changed 4 years ago by
 Branch u/dkrenn/asy/SAgeneratorlog deleted
comment:4 Changed 4 years ago by
 Branch set to u/dkrenn/zetainGF
comment:5 in reply to: ↑ 1 Changed 4 years ago by
 Commit set to d3b48c7070f8b3a7e0851c5ed6d62e5d95472a0a
 Status changed from new to needs_review
Replying to dkrenn:
We can either change to
.. MATH:: [z^n] \left(\frac{1}{1z/\zeta}\right)^\alpha \left(\frac{1}{z/\zeta} \log \frac{1}{1z/\zeta}\right)^\beta \left(\frac{1}{z/\zeta} \log \left(\frac{1}{z/\zeta} \log \frac{1}{1z/\zeta}\right)\right)^\delta.or prepend a
(1/\zeta)^n
to the formula.
The first choice does not look that bad, so I've prepared a patch.
Last 10 new commits:
c2f30f5  move code of NotImplementedOZero to avoid mergeconflicts

ebac5c2  Trac #20043: add additional doctest to check parent

33f675d  Merge branch 'u/dkrenn/asy/onetimeszero' of trac.sagemath.org:sage into t/19969/asy/SAgeneratorlog

98e1fc7  Trac #20043: make error message more precise and flexibel

99d7292  Merge branch 't/20043/asy/onetimeszero' into t/19969/asy/SAgeneratorlog

dd7dabf  Trac #19969: fix doctest

617e5bf  Trac #19969: rewrite output of doctest so that comparison with Formula in FlajoletSedgewick is easier

456d8c3  Trac #19969: correct whitespaces

b540598  Trac #19969: add an additional doctest

d3b48c7  Trac #20049: \zeta in GF in SingularityAnalysisgenerator

comment:6 Changed 4 years ago by
 Dependencies set to #19969
 Keywords singularity analysis added
 Reviewers set to Clemens Heuberger
 Status changed from needs_review to positive_review
LGTM
comment:7 Changed 4 years ago by
 Branch changed from u/dkrenn/zetainGF to d3b48c7070f8b3a7e0851c5ed6d62e5d95472a0a
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
We can either change to
or prepend a
(1/\zeta)^n
to the formula.