Opened 6 years ago

Closed 6 years ago

#20047 closed enhancement (fixed)

upgrade the sage notebook

Reported by: fbissey Owned by:
Priority: blocker Milestone: sage-7.1
Component: packages: standard Keywords:
Cc: kcrisman Merged in:
Authors: Karl-Dieter Crisman Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: a77ff01 (Commits, GitHub, GitLab) Commit: a77ff01dc97e2e7c8eec9fa205a95794a2d331be
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

#20030, #20016 and #20094 need a matching change in sagenb.

Upstream package is at http://sage.ugent.be/www/jdemeyer/sage/sagenb-0.11.7.tar

Change History (22)

comment:1 Changed 6 years ago by jdemeyer

  • Component changed from PLEASE CHANGE to packages: standard
  • Milestone changed from sage-pending to sage-7.1
  • Priority changed from major to blocker
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 6 years ago by jdemeyer

  • Cc kcrisman added
  • Description modified (diff)

comment:3 Changed 6 years ago by kcrisman

Don't have any more time tonight but I've merged all the things in question and will package soon. Sorry for some extra merge commits, btw.

comment:4 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 6 years ago by kcrisman

  • Branch set to u/kcrisman/ticket/20047

comment:6 Changed 6 years ago by kcrisman

  • Authors set to Karl-Dieter Crisman
  • Commit set to c1e219acf00081f08ea11b38f2e05b5d56ed60d0
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

c1e219aUpgrade sagenb to version 0.11.7

comment:7 Changed 6 years ago by kcrisman

I think I did everything correctly, try it out! Be sure to test that the notebook help works etc.

comment:8 Changed 6 years ago by jdemeyer

  • Branch changed from u/kcrisman/ticket/20047 to u/jdemeyer/ticket/20047

comment:9 Changed 6 years ago by jdemeyer

  • Commit changed from c1e219acf00081f08ea11b38f2e05b5d56ed60d0 to 6e0cdc06205160857600678f47cb625b03120487

Merged #20030 in the branch.


New commits:

f3d7236SAGE_DOC -> SAGE_DOC_SRC and SAGE_DOC_OUTPUT -> SAGE_DOC
1667635Ignore errors in symlinking
56ea5efMissing a SAGE_DOC_SRC in sagedoc.py
6e0cdc0Merge remote-tracking branch 'trac/u/fbissey/SAGE_DOC_SRC' into t/20047/ticket/20047

comment:10 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

It doesn't install for me:

Processing dependencies for Flask-AutoIndex==0.6
Searching for future>=0.13.0

Note: Bypassing https://pypi.python.org/simple/future/ (disallowed host; see http://bit.ly/1dg9ijs for details).

Couldn't find index page for 'future' (maybe misspelled?)
Scanning index of all packages (this may take a while)

Note: Bypassing https://pypi.python.org/simple/ (disallowed host; see http://bit.ly/1dg9ijs for details).

No local packages or download links found for future>=0.13.0
error: Could not find suitable distribution for Requirement.parse('future>=0.13.0')
Error: Installing Flask-AutoIndex-0.6.tar.gz failed.

comment:11 Changed 6 years ago by fbissey

Looks like the dependencies weren't packaged properly or something was included that shouldn't. For future I am guessing we are talking about http://python-future.org/.

comment:12 Changed 6 years ago by jdemeyer

Flask-AutoIndex was upgraded from 0.5 to 0.6. Is that upgrade required? If not, reverting it might solve this problem.

comment:13 Changed 6 years ago by fbissey

Compared to 0.11.6.1 I think all the dependency upgrade are gratuitous. All that was merged are the PR for the tickets in the summary. Sure it is good to keep on top but I don't think any of them are strictly necessary.

comment:14 Changed 6 years ago by kcrisman

No, no upgrades are required. But I don't know exactly how to (automatically, that is) revert such things. I guess I can do it manually by unpacking a previous tarball. I think that the dist.sh script just downloads whatever the most recent version is. I won't have time tomorrow for this, though.

comment:15 Changed 6 years ago by jdemeyer

I can repackage sagenb-0.11.7 by reverting to Flask-AutoIndex-0.5

comment:16 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_work to needs_review

comment:17 Changed 6 years ago by git

  • Commit changed from 6e0cdc06205160857600678f47cb625b03120487 to a77ff01dc97e2e7c8eec9fa205a95794a2d331be

Branch pushed to git repo; I updated commit sha1. New commits:

a77ff01Repackage sagenb with Flask-AutoIndex-0.5

comment:18 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Sorry, still doesn't work.

comment:19 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to needs_review

It does work. However, if you tested an old version of this ticket, you need to delete the previous installation of Flask-AutoIndex or you need make distclean.

comment:20 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to positive_review

Just tested it and SageNB seems to work fine.

I did find a serious bug https://github.com/sagemath/sagenb/issues/368 but given that it's also in the current sagenb, it shouldn't block this ticket.

comment:21 Changed 6 years ago by vbraun

  • Dependencies #20030 deleted

comment:22 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/20047 to a77ff01dc97e2e7c8eec9fa205a95794a2d331be
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.