Opened 4 years ago

Closed 4 years ago

#20043 closed defect (fixed)

AsymptoticRing: multiplication with zero fails

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords:
Cc: behackl, cheuberg Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 98e1fc7 (Commits) Commit: 98e1fc76e7cfa94d6f409e1b17acaad1b7ba96ac
Dependencies: Stopgaps:

Description

sage: A.<x> = AsymptoticRing('x^ZZ', ZZ)
A(1) * A(0)

fails.

Change History (8)

comment:1 Changed 4 years ago by dkrenn

  • Branch set to u/dkrenn/asy/one-times-zero

comment:2 Changed 4 years ago by dkrenn

  • Commit set to 2e2f4227cb6988d3359cac191045fcc50ae85c5a
  • Dependencies set to #19316

New commits:

d3194afMerge commit '37917b287453015084690b3b5dcbd6240f799ca4' of git://trac.sagemath.org/sage into asy/pow-var
f0a8292new NotImplementedOZero in misc
0af02b7remove old NotImplementedOZero and use new one
56c5473O(0) in asymptotic expansion
862c3d21*0 in asymptotic ring
ef5a6bbcorrect other empty sums
5e8d4e2fix O(0)-doctest
3817fc7forbid asymptotic rings as base in growth groups
2e2f422move code of NotImplementedOZero to avoid merge-conflicts

comment:3 Changed 4 years ago by git

  • Commit changed from 2e2f4227cb6988d3359cac191045fcc50ae85c5a to 83223e26eed72d49b3025851c8891b9d0a2f15c7

Branch pushed to git repo; I updated commit sha1. New commits:

83223e2Trac #20043: add additional doctest to check parent

comment:4 Changed 4 years ago by git

  • Commit changed from 83223e26eed72d49b3025851c8891b9d0a2f15c7 to ebac5c23514bbff6a3ff3bdebe4880773d6b3149

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ea85895new NotImplementedOZero in misc
d5c664eremove old NotImplementedOZero and use new one
143c048O(0) in asymptotic expansion
fb8a9d41*0 in asymptotic ring
b1c3f1bcorrect other empty sums
a87009dfix O(0)-doctest
ba0a5adforbid asymptotic rings as base in growth groups
c2f30f5move code of NotImplementedOZero to avoid merge-conflicts
ebac5c2Trac #20043: add additional doctest to check parent

comment:5 Changed 4 years ago by dkrenn

  • Dependencies #19316 deleted
  • Status changed from new to needs_review

Sits now on 7.1.beta3.

comment:6 Changed 4 years ago by git

  • Commit changed from ebac5c23514bbff6a3ff3bdebe4880773d6b3149 to 98e1fc76e7cfa94d6f409e1b17acaad1b7ba96ac

Branch pushed to git repo; I updated commit sha1. New commits:

98e1fc7Trac #20043: make error message more precise and flexibel

comment:7 Changed 4 years ago by cheuberg

  • Reviewers set to Clemens Heuberger
  • Status changed from needs_review to positive_review

LGTM

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/dkrenn/asy/one-times-zero to 98e1fc76e7cfa94d6f409e1b17acaad1b7ba96ac
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.