Opened 4 years ago

Closed 4 years ago

#20040 closed enhancement (fixed)

Singularity analysis method for log-type singularities

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords: singularity analysis
Cc: dkrenn, behackl Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 8bb9046 (Commits) Commit: 8bb904679aae25cb490a735fb492e43a672d356b
Dependencies: #19944, #20020 Stopgaps:

Description

Enhance #19944 to deal with log-type singularities.

Change History (15)

comment:1 Changed 4 years ago by cheuberg

  • Branch set to u/cheuberg/asy/singularity-analysis-method-log

comment:2 Changed 4 years ago by cheuberg

  • Commit set to 6b81bffe5fb96361a63b52839f4cf1c2fc3c3c3a
  • Status changed from new to needs_review

Last 10 new commits:

7c1d207Trac #19944: rewrite singularity analysis to use method of terms
5c66050Trac #19944: be more explicit w.r.t. parameter function
637147cTrac #19944: merge latest version of #19993
bfd8f2fMerge branch 't/19944/asy/singularity-analysis-method' into asy/singularity-analysis-method-log
44515f6Trac #20040: method gens_logarithmic
c8665a2Trac #20040: singularity analysis for terms log(n)^k
76f0b74Trac #20040: singularity analysis for cartesian products with one factor
4a95037Trac #20040: singularity analysis method allows single logs
6f595eeTrac #20040: Singularity analysis of two factors
6b81bffTrac #20040: additional doctest (harmonic numbers)

comment:3 Changed 4 years ago by dkrenn

  • Branch changed from u/cheuberg/asy/singularity-analysis-method-log to u/dkrenn/asy/singularity-analysis-method-log

comment:4 Changed 4 years ago by cheuberg

  • Commit changed from 6b81bffe5fb96361a63b52839f4cf1c2fc3c3c3a to b6ffdaa28207bb0f48df8d868ebb84d0d90a6cb7

cross-reviewed your changes.


Last 10 new commits:

33f675dMerge branch 'u/dkrenn/asy/one-times-zero' of trac.sagemath.org:sage into t/19969/asy/SA-generator-log
a9e618eMerge branch 'u/dkrenn/asy/SA-generator-log' of trac.sagemath.org:sage into t/19944/asy/singularity-analysis-method
98e1fc7Trac #20043: make error message more precise and flexibel
99d7292Merge branch 't/20043/asy/one-times-zero' into t/19969/asy/SA-generator-log
dd7dabfTrac #19969: fix doctest
88f278dMerge branch 't/19969/asy/SA-generator-log' into HEAD
46d91b3Trac #19944: fix doctests and code
0624f6aMerge branch 'u/dkrenn/asy/singularity-analysis-method' of trac.sagemath.org:sage into t/20040/asy/singularity-analysis-method-log
a9ec510Trac #20040: extend NotImplementedOZero to allow passing var directly
b6ffdaaTrac #20040: fix doctests

comment:5 Changed 4 years ago by git

  • Commit changed from b6ffdaa28207bb0f48df8d868ebb84d0d90a6cb7 to a6a844fcc477c375b65d5982df07e1c72d92be00

Branch pushed to git repo; I updated commit sha1. New commits:

617e5bfTrac #19969: rewrite output of doctest so that comparison with Formula in Flajolet-Sedgewick is easier
456d8c3Trac #19969: correct whitespaces
b540598Trac #19969: add an additional doctest
984ca4dMerge branch 'u/dkrenn/asy/SA-generator-log' of git://trac.sagemath.org/sage into t/19944/asy/singularity-analysis-method
e1e2ef3Trac #19944: minor restructure of code
97249e7Trac #19944: minor improvement of docstrings (whitespaces, punctation, ...)
ad62c31Trac #19944: show element in NotImplementedError
abf2b7aMerge branch 'u/dkrenn/asy/singularity-analysis-method' of git://trac.sagemath.org/sage into t/20040/asy/singularity-analysis-method-log
a6a844fTrac #20040: fix doctests after merge of #19944

comment:6 follow-up: Changed 4 years ago by cheuberg

I cross-reviewed your changes so far and will now merge the newest version of #19944 and continue the changes (order of parameters, named parameter precision) here.

comment:7 Changed 4 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/singularity-analysis-method-log to u/cheuberg/asy/singularity-analysis-method-log

comment:8 in reply to: ↑ 6 Changed 4 years ago by cheuberg

  • Commit changed from a6a844fcc477c375b65d5982df07e1c72d92be00 to d0f5e940d0a00895376472396c6e4f57e8bbc901

Replying to cheuberg:

I cross-reviewed your changes so far and will now merge the newest version of #19944 and continue the changes (order of parameters, named parameter precision) here.

Done.


New commits:

9ce7b35Trac #19944: exchange order of parameters var and zeta in _singularity_analysis_
902c182Trac #20040: Merge #19944
866a9e3Trac #20040: exchange order of parameters var and zeta in _singularity_analysis_
c79a6f7Trac #19944: exchange zeta and var in docstrings
d0f5e94Trac #20040: Merge #19944

comment:9 Changed 4 years ago by dkrenn

  • Branch changed from u/cheuberg/asy/singularity-analysis-method-log to u/dkrenn/asy/singularity-analysis-method-log

comment:10 follow-up: Changed 4 years ago by dkrenn

  • Commit changed from d0f5e940d0a00895376472396c6e4f57e8bbc901 to 27a86054f04e19531bbb90f9638d99f9d4eb7c73

I've finished my review and cross-reviewed your latest changes. I've also added a couple of small commits which need a cross-review. If ok, then feel free to give this ticket a positive review.


New commits:

1ed6067Merge branch 'u/dkrenn/asy/SA-generator-log' of trac.sagemath.org:sage into t/20020/asy/singularity-generator-log-non-normalized
931e5dfMerge branch 'u/dkrenn/asy/SA-generator-log' of git://trac.sagemath.org/sage into t/20020/asy/singularity-generator-log-non-normalized
4462b27Trac #20020: correct whitespaces
60790f5Merge branch 'u/dkrenn/asy/singularity-generator-log-non-normalized' of git://trac.sagemath.org/sage into t/20040/asy/singularity-analysis-method-log
1276422Trac #20040: whitespaces
5e9cffbTrac # 20040: unify NotImplementedError-message
a1c4498Trac #20040: minor code rewrite for readability
4dae56dTrac #20040: unify all NotImplementedError-messages
27a8605Merge branch 'u/cheuberg/asy/singularity-analysis-method-log' of git://trac.sagemath.org/sage into t/20040/asy/singularity-analysis-method-log

comment:11 Changed 4 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/singularity-analysis-method-log to u/cheuberg/asy/singularity-analysis-method-log

comment:12 in reply to: ↑ 10 ; follow-up: Changed 4 years ago by cheuberg

  • Commit changed from 27a86054f04e19531bbb90f9638d99f9d4eb7c73 to 8bb904679aae25cb490a735fb492e43a672d356b

Replying to dkrenn:

I've finished my review and cross-reviewed your latest changes. I've also added a couple of small commits which need a cross-review. If ok, then feel free to give this ticket a positive review.

cross-reviewed. Added another two commits which need a brief review.


New commits:

452c43bTrac #19944: _singularity_analysis_ methods: more precise documentation
4cb5934Trac #20040: Merge #19944
8455dc2Trac #20040: _singularity_analysis_ methods: more precise documentation
8bb9046Trac #20040: added myself to AUTHORS

comment:13 in reply to: ↑ 12 Changed 4 years ago by dkrenn

  • Status changed from needs_review to positive_review

Replying to cheuberg:

cross-reviewed. Added another two commits which need a brief review.

Fine.

comment:14 Changed 4 years ago by dkrenn

  • Reviewers set to Daniel Krenn

comment:15 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/asy/singularity-analysis-method-log to 8bb904679aae25cb490a735fb492e43a672d356b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.