Opened 5 years ago
Closed 5 years ago
#20040 closed enhancement (fixed)
Singularity analysis method for logtype singularities
Reported by:  cheuberg  Owned by:  

Priority:  major  Milestone:  sage7.1 
Component:  asymptotic expansions  Keywords:  singularity analysis 
Cc:  dkrenn, behackl  Merged in:  
Authors:  Clemens Heuberger  Reviewers:  Daniel Krenn 
Report Upstream:  N/A  Work issues:  
Branch:  8bb9046 (Commits)  Commit:  8bb904679aae25cb490a735fb492e43a672d356b 
Dependencies:  #19944, #20020  Stopgaps: 
Description
Enhance #19944 to deal with logtype singularities.
Change History (15)
comment:1 Changed 5 years ago by
 Branch set to u/cheuberg/asy/singularityanalysismethodlog
comment:2 Changed 5 years ago by
 Commit set to 6b81bffe5fb96361a63b52839f4cf1c2fc3c3c3a
 Status changed from new to needs_review
comment:3 Changed 5 years ago by
 Branch changed from u/cheuberg/asy/singularityanalysismethodlog to u/dkrenn/asy/singularityanalysismethodlog
comment:4 Changed 5 years ago by
 Commit changed from 6b81bffe5fb96361a63b52839f4cf1c2fc3c3c3a to b6ffdaa28207bb0f48df8d868ebb84d0d90a6cb7
crossreviewed your changes.
Last 10 new commits:
33f675d  Merge branch 'u/dkrenn/asy/onetimeszero' of trac.sagemath.org:sage into t/19969/asy/SAgeneratorlog

a9e618e  Merge branch 'u/dkrenn/asy/SAgeneratorlog' of trac.sagemath.org:sage into t/19944/asy/singularityanalysismethod

98e1fc7  Trac #20043: make error message more precise and flexibel

99d7292  Merge branch 't/20043/asy/onetimeszero' into t/19969/asy/SAgeneratorlog

dd7dabf  Trac #19969: fix doctest

88f278d  Merge branch 't/19969/asy/SAgeneratorlog' into HEAD

46d91b3  Trac #19944: fix doctests and code

0624f6a  Merge branch 'u/dkrenn/asy/singularityanalysismethod' of trac.sagemath.org:sage into t/20040/asy/singularityanalysismethodlog

a9ec510  Trac #20040: extend NotImplementedOZero to allow passing var directly

b6ffdaa  Trac #20040: fix doctests

comment:5 Changed 5 years ago by
 Commit changed from b6ffdaa28207bb0f48df8d868ebb84d0d90a6cb7 to a6a844fcc477c375b65d5982df07e1c72d92be00
Branch pushed to git repo; I updated commit sha1. New commits:
617e5bf  Trac #19969: rewrite output of doctest so that comparison with Formula in FlajoletSedgewick is easier

456d8c3  Trac #19969: correct whitespaces

b540598  Trac #19969: add an additional doctest

984ca4d  Merge branch 'u/dkrenn/asy/SAgeneratorlog' of git://trac.sagemath.org/sage into t/19944/asy/singularityanalysismethod

e1e2ef3  Trac #19944: minor restructure of code

97249e7  Trac #19944: minor improvement of docstrings (whitespaces, punctation, ...)

ad62c31  Trac #19944: show element in NotImplementedError

abf2b7a  Merge branch 'u/dkrenn/asy/singularityanalysismethod' of git://trac.sagemath.org/sage into t/20040/asy/singularityanalysismethodlog

a6a844f  Trac #20040: fix doctests after merge of #19944

comment:6 followup: ↓ 8 Changed 5 years ago by
I crossreviewed your changes so far and will now merge the newest version of #19944 and continue the changes (order of parameters, named parameter precision
) here.
comment:7 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/singularityanalysismethodlog to u/cheuberg/asy/singularityanalysismethodlog
comment:8 in reply to: ↑ 6 Changed 5 years ago by
 Commit changed from a6a844fcc477c375b65d5982df07e1c72d92be00 to d0f5e940d0a00895376472396c6e4f57e8bbc901
Replying to cheuberg:
I crossreviewed your changes so far and will now merge the newest version of #19944 and continue the changes (order of parameters, named parameter
precision
) here.
Done.
New commits:
9ce7b35  Trac #19944: exchange order of parameters var and zeta in _singularity_analysis_

902c182  Trac #20040: Merge #19944

866a9e3  Trac #20040: exchange order of parameters var and zeta in _singularity_analysis_

c79a6f7  Trac #19944: exchange zeta and var in docstrings

d0f5e94  Trac #20040: Merge #19944

comment:9 Changed 5 years ago by
 Branch changed from u/cheuberg/asy/singularityanalysismethodlog to u/dkrenn/asy/singularityanalysismethodlog
comment:10 followup: ↓ 12 Changed 5 years ago by
 Commit changed from d0f5e940d0a00895376472396c6e4f57e8bbc901 to 27a86054f04e19531bbb90f9638d99f9d4eb7c73
I've finished my review and crossreviewed your latest changes. I've also added a couple of small commits which need a crossreview. If ok, then feel free to give this ticket a positive review.
New commits:
1ed6067  Merge branch 'u/dkrenn/asy/SAgeneratorlog' of trac.sagemath.org:sage into t/20020/asy/singularitygeneratorlognonnormalized

931e5df  Merge branch 'u/dkrenn/asy/SAgeneratorlog' of git://trac.sagemath.org/sage into t/20020/asy/singularitygeneratorlognonnormalized

4462b27  Trac #20020: correct whitespaces

60790f5  Merge branch 'u/dkrenn/asy/singularitygeneratorlognonnormalized' of git://trac.sagemath.org/sage into t/20040/asy/singularityanalysismethodlog

1276422  Trac #20040: whitespaces

5e9cffb  Trac # 20040: unify NotImplementedErrormessage

a1c4498  Trac #20040: minor code rewrite for readability

4dae56d  Trac #20040: unify all NotImplementedErrormessages

27a8605  Merge branch 'u/cheuberg/asy/singularityanalysismethodlog' of git://trac.sagemath.org/sage into t/20040/asy/singularityanalysismethodlog

comment:11 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/singularityanalysismethodlog to u/cheuberg/asy/singularityanalysismethodlog
comment:12 in reply to: ↑ 10 ; followup: ↓ 13 Changed 5 years ago by
 Commit changed from 27a86054f04e19531bbb90f9638d99f9d4eb7c73 to 8bb904679aae25cb490a735fb492e43a672d356b
Replying to dkrenn:
I've finished my review and crossreviewed your latest changes. I've also added a couple of small commits which need a crossreview. If ok, then feel free to give this ticket a positive review.
crossreviewed. Added another two commits which need a brief review.
New commits:
452c43b  Trac #19944: _singularity_analysis_ methods: more precise documentation

4cb5934  Trac #20040: Merge #19944

8455dc2  Trac #20040: _singularity_analysis_ methods: more precise documentation

8bb9046  Trac #20040: added myself to AUTHORS

comment:13 in reply to: ↑ 12 Changed 5 years ago by
 Status changed from needs_review to positive_review
comment:14 Changed 5 years ago by
 Reviewers set to Daniel Krenn
comment:15 Changed 5 years ago by
 Branch changed from u/cheuberg/asy/singularityanalysismethodlog to 8bb904679aae25cb490a735fb492e43a672d356b
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
Trac #19944: rewrite singularity analysis to use method of terms
Trac #19944: be more explicit w.r.t. parameter function
Trac #19944: merge latest version of #19993
Merge branch 't/19944/asy/singularityanalysismethod' into asy/singularityanalysismethodlog
Trac #20040: method gens_logarithmic
Trac #20040: singularity analysis for terms log(n)^k
Trac #20040: singularity analysis for cartesian products with one factor
Trac #20040: singularity analysis method allows single logs
Trac #20040: Singularity analysis of two factors
Trac #20040: additional doctest (harmonic numbers)