Opened 5 years ago
Closed 5 years ago
#20030 closed enhancement (duplicate)
Change SAGE_DOC environment variables
Reported by:  jdemeyer  Owned by:  

Priority:  blocker  Milestone:  sageduplicate/invalid/wontfix 
Component:  misc  Keywords:  
Cc:  fbissey  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  François Bissey 
Report Upstream:  N/A  Work issues:  
Branch:  u/fbissey/SAGE_DOC_SRC (Commits, GitHub, GitLab)  Commit:  56ea5ef6732e1ffa4036fdd90c8404f715e5df36 
Dependencies:  Stopgaps: 
Description (last modified by )
Replace
SAGE_DOC
> SAGE_DOC_SRC
SAGE_DOC_OUTPUT
> SAGE_DOC
Merge with #20047
Change History (21)
comment:1 Changed 5 years ago by
 Dependencies set to #19963
comment:2 Changed 5 years ago by
 Branch set to u/jdemeyer/SAGE_DOC_SRC
comment:3 Changed 5 years ago by
 Commit set to f3d7236bf4363bc9aeb64fbe19e487da0b1914fb
 Status changed from new to needs_review
comment:4 Changed 5 years ago by
 Commit changed from f3d7236bf4363bc9aeb64fbe19e487da0b1914fb to 16676356641ffd1468d560104f4df1f367d74fa4
Branch pushed to git repo; I updated commit sha1. New commits:
1667635  Ignore errors in symlinking

comment:5 Changed 5 years ago by
 Reviewers set to François Bissey
 Status changed from needs_review to positive_review
Looks good to me.
comment:6 Changed 5 years ago by
 Status changed from positive_review to needs_work
Breaks incremental updates
File "src/sage/misc/sageinspect.py", line 25, in sage.misc.sageinspect Failed example: sage_getdoc(sage.rings.rational).lstrip() Exception raised: Traceback (most recent call last): File "/home/buildslavesage/slave/sage_git/build/local/lib/python2.7/sitepackages/sage/doctest/forker.py", line 496, in _run self.compile_and_execute(example, compiler, test.globs) File "/home/buildslavesage/slave/sage_git/build/local/lib/python2.7/sitepackages/sage/doctest/forker.py", line 858, in compile_and_execute exec(compiled, globs) File "<doctest sage.misc.sageinspect[2]>", line 1, in <module> sage_getdoc(sage.rings.rational).lstrip() File "/home/buildslavesage/slave/sage_git/build/local/lib/python2.7/sitepackages/sage/misc/sageinspect.py", line 1829, in sage_getdoc s = sage.misc.sagedoc.format(r, embedded=(embedded_override or EMBEDDED_MODE)) File "/home/buildslavesage/slave/sage_git/build/local/lib/python2.7/sitepackages/sage/misc/sagedoc.py", line 664, in format s = detex(s, embedded=embedded) File "/home/buildslavesage/slave/sage_git/build/local/lib/python2.7/sitepackages/sage/misc/sagedoc.py", line 219, in detex s = sphinxify(s, format='text') File "/home/buildslavesage/slave/sage_git/build/local/lib/python2.7/sitepackages/sagenb0.11.6.1py2.7.egg/sagenb/misc/sphinxify.py", line 121, in sphinxify confoverrides, None, None, True) File "/home/buildslavesage/slave/sage_git/build/local/lib/python2.7/sitepackages/Sphinx1.2.2py2.7.egg/sphinx/application.py", line 107, in __init__ confoverrides or {}, self.tags) File "/home/buildslavesage/slave/sage_git/build/local/lib/python2.7/sitepackages/Sphinx1.2.2py2.7.egg/sphinx/config.py", line 227, in __init__ os.chdir(dirname) OSError: [Errno 2] No such file or directory: '/home/buildslavesage/slave/sage_git/build/local/share/doc/sage/en/introspect'
comment:7 Changed 5 years ago by
Yes I have now noticed in the last hour that this change would require to have at least en/introspect/conf.py
and common/conf.py
in the doc folder, shipped under the new SAGE_DOC
. Alternatively the function generate_configuration
in the sage notebook at sagenb/misc/sphinxify.py
needs to be fixed. I would be quite eager for it to be.
However including https://github.com/sagemath/sagenb/pull/363 in sagenb
would be sufficient to fix the problem.
comment:8 Changed 5 years ago by
Why is sphinxify.py
part of sagenb
rather than sage
? I think the functionality should be moved in the future, especially if we want to deprecate sagenb
.
comment:9 Changed 5 years ago by
Yes, I was also very surprised to see that.
comment:10 Changed 5 years ago by
 Milestone changed from sage7.1 to sagepending
 Status changed from needs_work to positive_review
comment:11 Changed 5 years ago by
 Status changed from positive_review to needs_work
Found one error, line 804 of sagedoc.py
needs to be changed from SAGE_DOC
to SAGE_DOC_SRC
.
comment:12 Changed 5 years ago by
 Branch changed from u/jdemeyer/SAGE_DOC_SRC to u/fbissey/SAGE_DOC_SRC
 Commit changed from 16676356641ffd1468d560104f4df1f367d74fa4 to 56ea5ef6732e1ffa4036fdd90c8404f715e5df36
comment:13 Changed 5 years ago by
 Status changed from needs_work to positive_review
comment:14 Changed 5 years ago by
#20047 is for the matching change in sagenb
.
comment:15 Changed 5 years ago by
 Dependencies #19963 deleted
 Description modified (diff)
comment:16 followup: ↓ 17 Changed 5 years ago by
still pending?
comment:17 in reply to: ↑ 16 Changed 5 years ago by
comment:18 Changed 5 years ago by
This should be merged through #20047, which contains the branch here. Not sure which milestone I should set then.
comment:19 Changed 5 years ago by
comment:20 Changed 5 years ago by
OK, then you can just close this ticket when you merge #20047.
comment:21 Changed 5 years ago by
 Milestone changed from sagepending to sageduplicate/invalid/wontfix
 Resolution set to duplicate
 Status changed from positive_review to closed
New commits:
Fix citation dir with custom SAGE_DOC_OUTPUT
Build documentation in $SAGE_SHARE/doc/sage
Minor fixes to toplevel build system
Remove old src/doc/ouput and .pyc files
Add symbolic link SAGE_DOC/output > SAGE_DOC_OUTPUT
Use new documentation paths in documentation
Fix a few more paths
SAGE_DOC > SAGE_DOC_SRC and SAGE_DOC_OUTPUT > SAGE_DOC