Opened 6 years ago
Closed 7 months ago
#20023 closed task (fixed)
sage_bootstrap: Remove purported Python 2.6 support
Reported by:  vbraun  Owned by:  

Priority:  critical  Milestone:  sage9.3 
Component:  build  Keywords:  
Cc:  chapoton, dimpase, embray, fbissey, jdemeyer, slelievre, jhpalmieri  Merged in:  
Authors:  Dima Pasechnik, Matthias Koeppe  Reviewers:  Matthias Koeppe, Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  8cd0bcc (Commits, GitHub, GitLab)  Commit:  8cd0bccfdfeba58331e92087b1f2bacf7248c9e4 
Dependencies:  #29890, #31419, #31318  Stopgaps: 
Description (last modified by )
 Apparently sagebootstrappython using python 2.6 is broken already  https://groups.google.com/g/sagesupport/c/GniJKQ0MaMY/m/DugFUprJAwAJ
 Platforms such as RHEL 6 and Centos 6 reached their EOL at the end of 2020; and Dockerbased testing of
centos6
no longer works
In this ticket, we
 delete
sage_bootstrap/compat/argparse.py
 Change http://doc.sagemath.org/html/en/developer/packaging.html#checksums and any other related documentation (last modified in #31192)
This is on top of #31419 so that we have to change README
only once.
Change History (47)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
This can also help with #9536 since Python 2.7+ supports the nousercfg
option to setup.py
/setup.cfg
, which Python 2.6 does not (just thought of this since it's an issue I looked at recently).
comment:3 Changed 5 years ago by
 Cc dimpase added
 Dependencies set to #19984
 Description modified (diff)
 Summary changed from Remove Python 2.6 support to Remove Python 2.6 support at some future point
comment:4 Changed 5 years ago by
 Milestone changed from sage7.1 to sagewishlist
 Type changed from enhancement to task
comment:5 Changed 2 years ago by
 Cc chapoton embray fbissey jdemeyer slelievre added
See #28000 for complete removal of Python 2 support.
comment:6 Changed 2 years ago by
I'm pretty sure Python 2.6 support is completely removed from sagelib itself, just not from sage_bootstrap.
comment:7 Changed 2 years ago by
should we clean up sage_bootstrap
in this respect here? (this would mean to require system's Python 2.7 or better for building)
comment:8 Changed 2 years ago by
Removing the ability to bootstrap from Python 2.6 probably does not need to happen before we remove Python 2 support in sagelib.
comment:9 Changed 2 years ago by
From the brief look at the code, this is a change that may be done now, and after all noone must Python 2.6 now.
comment:10 Changed 2 years ago by
It's the default python on redhat/centos 6 and possibly some ancient debian. I'll note that redhat/centos 6 have access to newer python but someone with admin privileges and knowledge of software collections is needed.
comment:11 Changed 16 months ago by
 Summary changed from Remove Python 2.6 support at some future point to sage_bootstrap: Remove Python 2.6 support at some future point
comment:12 Changed 16 months ago by
I'll make an experimental branch to remove vendored argparse
comment:13 Changed 16 months ago by
 Branch set to u/dimpase/build/unvendorargparse
 Commit set to 2d0891df1a2df77fc7eb68e6b69015e05b25c38e
 Dependencies #19984 deleted
New commits:
2d0891d  remove vendored argparse

comment:14 Changed 16 months ago by
tests run on https://github.com/dimpase/sage/pull/11
comment:15 Changed 16 months ago by
 Status changed from new to needs_review
comment:16 Changed 16 months ago by
Also need to update build/tox.ini
comment:17 Changed 16 months ago by
 Commit changed from 2d0891df1a2df77fc7eb68e6b69015e05b25c38e to f734c8ea9a7629e4ed787c12b866d70ebfd5251f
Branch pushed to git repo; I updated commit sha1. New commits:
f734c8e  remove py26 from tox

comment:18 Changed 16 months ago by
 Reviewers set to Matthias Koeppe
 Status changed from needs_review to positive_review
 Summary changed from sage_bootstrap: Remove Python 2.6 support at some future point to sage_bootstrap: Remove Python 2.6 support
comment:19 Changed 16 months ago by
 Milestone changed from sagewishlist to sage9.2
 Status changed from positive_review to needs_work
comment:20 Changed 16 months ago by
sagesystempython
should probably check that python
is new enough.
comment:21 Changed 16 months ago by
 Dependencies set to #29890
comment:22 Changed 16 months ago by
 Milestone changed from sage9.2 to sagepending
 Status changed from needs_work to needs_review
comment:23 Changed 16 months ago by
comment:24 Changed 16 months ago by
 Branch changed from u/dimpase/build/unvendorargparse to u/mkoeppe/build/unvendorargparse
comment:25 Changed 16 months ago by
 Cc jhpalmieri added
 Commit changed from f734c8ea9a7629e4ed787c12b866d70ebfd5251f to 5ff700a02cd06952b167b9aeb26888bbfc5c74cc
comment:26 Changed 16 months ago by
I set it to sagepending
because I think 9.2 may be too early to merge this ticket.
comment:27 Changed 12 months ago by
 Milestone changed from sagepending to sage9.3
needs a rebase  set milestone to 9.3
comment:28 Changed 12 months ago by
 Status changed from needs_review to needs_work
comment:29 Changed 12 months ago by
 Priority changed from major to minor
comment:30 Changed 10 months ago by
it seems that the branch ought to remove build/sage_bootstrap/compat
, no?
comment:31 Changed 10 months ago by
 Milestone changed from sage9.3 to sagepending
I think sage 9.3 is still too early for removing the support for building the distribution on systems that only have python 2.6. Setting the milestone back to pending
comment:32 Changed 8 months ago by
 Description modified (diff)
 Summary changed from sage_bootstrap: Remove Python 2.6 support to sage_bootstrap: Remove purported Python 2.6 support
comment:33 Changed 8 months ago by
 Description modified (diff)
 Milestone changed from sagepending to sage9.3
 Priority changed from minor to critical
comment:34 Changed 8 months ago by
 Commit changed from 5ff700a02cd06952b167b9aeb26888bbfc5c74cc to 0f3d369ec518c5084ef17976b72498f8e694887a
comment:35 Changed 8 months ago by
 Commit changed from 0f3d369ec518c5084ef17976b72498f8e694887a to 86c05e6412c95482fb46b5570b0e59e7b636c066
Branch pushed to git repo; I updated commit sha1. New commits:
86c05e6  src/doc/en/installation/source.rst: sagebootstrappython cannot be 2.6

comment:36 Changed 8 months ago by
 Commit changed from 86c05e6412c95482fb46b5570b0e59e7b636c066 to 06873c2264c5a228eb8fe0ae7a7fa1b4b58fcc88
comment:37 Changed 8 months ago by
 Dependencies changed from #29890 to #29890, #31419
 Description modified (diff)
 Status changed from needs_work to needs_review
comment:38 Changed 8 months ago by
 Reviewers changed from Matthias Koeppe to Matthias Koeppe, ...
comment:39 Changed 8 months ago by
should we also remove py33
from build/tox.ini
?
comment:40 Changed 8 months ago by
 Commit changed from 06873c2264c5a228eb8fe0ae7a7fa1b4b58fcc88 to c948b02d1ec33cdc3a8bfc9603faf729fbb22402
Branch pushed to git repo; I updated commit sha1. New commits:
c948b02  build/tox.ini: Remove py33, add py39, py310

comment:41 Changed 8 months ago by
 Reviewers changed from Matthias Koeppe, ... to Matthias Koeppe, Dima Pasechnik
 Status changed from needs_review to positive_review
OK, this works
comment:42 Changed 8 months ago by
Thanks.
comment:44 Changed 8 months ago by
 Commit changed from c948b02d1ec33cdc3a8bfc9603faf729fbb22402 to b1fe92979131e2ea2e357a37a1b57deb7051fc6a
comment:45 Changed 8 months ago by
 Commit changed from b1fe92979131e2ea2e357a37a1b57deb7051fc6a to 8cd0bccfdfeba58331e92087b1f2bacf7248c9e4
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
6ef52d6  build/pkgs/python3/spkgconfigure.m4: Issue a deprecation warning for system python 3.6

cf55561  Merge branch 't/31192/installation_manual__fix_documentation_of_python_prerequisite__sage_bootstrap_python_' into t/31318/python3_spkg_configure_m4__add_deprecation_warning_regarding_system_python_3_6

0fb8646  README.md, src/doc/en/installation/source.rst: Mention/update version range for python3

8cd0bcc  Merge #31318

comment:46 Changed 8 months ago by
 Dependencies changed from #29890, #31419 to #29890, #31419, #31318
 Status changed from needs_work to positive_review
comment:47 Changed 7 months ago by
 Branch changed from u/mkoeppe/build/unvendorargparse to 8cd0bccfdfeba58331e92087b1f2bacf7248c9e4
 Resolution set to fixed
 Status changed from positive_review to closed
I changed the directory to
SAGE_ROOT/build/sage_bootstrap
and checked out contents : ` . ├── cksum.py ├── cmdline.py ├── compat.py ├── config.py ├── download.py ├── env.py ├── init.py ├── levenshtein.py ├── logger.py ├── mirror_list.py ├── package.py ├── README ├── stdio.py ├── tarball.py └── updater.py`
There is no subdirectory named "compat".