Opened 7 years ago
Closed 2 years ago
#20023 closed task (fixed)
sage_bootstrap: Remove purported Python 2.6 support
Reported by:  vbraun  Owned by:  

Priority:  critical  Milestone:  sage9.3 
Component:  build  Keywords:  
Cc:  chapoton, dimpase, embray, fbissey, jdemeyer, slelievre, jhpalmieri  Merged in:  
Authors:  Dima Pasechnik, Matthias Koeppe  Reviewers:  Matthias Koeppe, Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  8cd0bcc (Commits, GitHub, GitLab)  Commit:  8cd0bccfdfeba58331e92087b1f2bacf7248c9e4 
Dependencies:  #29890, #31419, #31318  Stopgaps: 
Description (last modified by )
 Apparently sagebootstrappython using python 2.6 is broken already  https://groups.google.com/g/sagesupport/c/GniJKQ0MaMY/m/DugFUprJAwAJ
 Platforms such as RHEL 6 and Centos 6 reached their EOL at the end of 2020; and Dockerbased testing of
centos6
no longer works
In this ticket, we
 delete
sage_bootstrap/compat/argparse.py
 Change http://doc.sagemath.org/html/en/developer/packaging.html#checksums and any other related documentation (last modified in #31192)
This is on top of #31419 so that we have to change README
only once.
Change History (47)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
This can also help with #9536 since Python 2.7+ supports the nousercfg
option to setup.py
/setup.cfg
, which Python 2.6 does not (just thought of this since it's an issue I looked at recently).
comment:3 Changed 7 years ago by
Cc:  dimpase added 

Dependencies:  → #19984 
Description:  modified (diff) 
Summary:  Remove Python 2.6 support → Remove Python 2.6 support at some future point 
comment:4 Changed 7 years ago by
Milestone:  sage7.1 → sagewishlist 

Type:  enhancement → task 
comment:5 Changed 4 years ago by
Cc:  chapoton embray fbissey jdemeyer slelievre added 

See #28000 for complete removal of Python 2 support.
comment:6 Changed 4 years ago by
I'm pretty sure Python 2.6 support is completely removed from sagelib itself, just not from sage_bootstrap.
comment:7 Changed 4 years ago by
should we clean up sage_bootstrap
in this respect here? (this would mean to require system's Python 2.7 or better for building)
comment:8 Changed 4 years ago by
Removing the ability to bootstrap from Python 2.6 probably does not need to happen before we remove Python 2 support in sagelib.
comment:9 Changed 4 years ago by
From the brief look at the code, this is a change that may be done now, and after all noone must Python 2.6 now.
comment:10 Changed 4 years ago by
It's the default python on redhat/centos 6 and possibly some ancient debian. I'll note that redhat/centos 6 have access to newer python but someone with admin privileges and knowledge of software collections is needed.
comment:11 Changed 3 years ago by
Summary:  Remove Python 2.6 support at some future point → sage_bootstrap: Remove Python 2.6 support at some future point 

comment:13 Changed 3 years ago by
Authors:  → Dima Pasechnik 

Branch:  → u/dimpase/build/unvendorargparse 
Commit:  → 2d0891df1a2df77fc7eb68e6b69015e05b25c38e 
Dependencies:  #19984 
New commits:
2d0891d  remove vendored argparse

comment:15 Changed 3 years ago by
Status:  new → needs_review 

comment:17 Changed 3 years ago by
Commit:  2d0891df1a2df77fc7eb68e6b69015e05b25c38e → f734c8ea9a7629e4ed787c12b866d70ebfd5251f 

Branch pushed to git repo; I updated commit sha1. New commits:
f734c8e  remove py26 from tox

comment:18 Changed 3 years ago by
Reviewers:  → Matthias Koeppe 

Status:  needs_review → positive_review 
Summary:  sage_bootstrap: Remove Python 2.6 support at some future point → sage_bootstrap: Remove Python 2.6 support 
comment:19 Changed 3 years ago by
Milestone:  sagewishlist → sage9.2 

Status:  positive_review → needs_work 
comment:20 Changed 3 years ago by
sagesystempython
should probably check that python
is new enough.
comment:21 Changed 3 years ago by
Dependencies:  → #29890 

comment:22 Changed 3 years ago by
Milestone:  sage9.2 → sagepending 

Status:  needs_work → needs_review 
comment:23 Changed 3 years ago by
Authors:  Dima Pasechnik → Dima Pasechnik, Matthias Koeppe 

comment:24 Changed 3 years ago by
Branch:  u/dimpase/build/unvendorargparse → u/mkoeppe/build/unvendorargparse 

comment:25 Changed 3 years ago by
Cc:  jhpalmieri added 

Commit:  f734c8ea9a7629e4ed787c12b866d70ebfd5251f → 5ff700a02cd06952b167b9aeb26888bbfc5c74cc 
comment:26 Changed 3 years ago by
I set it to sagepending
because I think 9.2 may be too early to merge this ticket.
comment:27 Changed 2 years ago by
Milestone:  sagepending → sage9.3 

needs a rebase  set milestone to 9.3
comment:28 Changed 2 years ago by
Status:  needs_review → needs_work 

comment:29 Changed 2 years ago by
Priority:  major → minor 

comment:30 Changed 2 years ago by
it seems that the branch ought to remove build/sage_bootstrap/compat
, no?
comment:31 Changed 2 years ago by
Milestone:  sage9.3 → sagepending 

I think sage 9.3 is still too early for removing the support for building the distribution on systems that only have python 2.6. Setting the milestone back to pending
comment:32 Changed 2 years ago by
Description:  modified (diff) 

Summary:  sage_bootstrap: Remove Python 2.6 support → sage_bootstrap: Remove purported Python 2.6 support 
comment:33 Changed 2 years ago by
Description:  modified (diff) 

Milestone:  sagepending → sage9.3 
Priority:  minor → critical 
comment:34 Changed 2 years ago by
Commit:  5ff700a02cd06952b167b9aeb26888bbfc5c74cc → 0f3d369ec518c5084ef17976b72498f8e694887a 

comment:35 Changed 2 years ago by
Commit:  0f3d369ec518c5084ef17976b72498f8e694887a → 86c05e6412c95482fb46b5570b0e59e7b636c066 

Branch pushed to git repo; I updated commit sha1. New commits:
86c05e6  src/doc/en/installation/source.rst: sagebootstrappython cannot be 2.6

comment:36 Changed 2 years ago by
Commit:  86c05e6412c95482fb46b5570b0e59e7b636c066 → 06873c2264c5a228eb8fe0ae7a7fa1b4b58fcc88 

comment:37 Changed 2 years ago by
Dependencies:  #29890 → #29890, #31419 

Description:  modified (diff) 
Status:  needs_work → needs_review 
comment:38 Changed 2 years ago by
Reviewers:  Matthias Koeppe → Matthias Koeppe, ... 

comment:40 Changed 2 years ago by
Commit:  06873c2264c5a228eb8fe0ae7a7fa1b4b58fcc88 → c948b02d1ec33cdc3a8bfc9603faf729fbb22402 

Branch pushed to git repo; I updated commit sha1. New commits:
c948b02  build/tox.ini: Remove py33, add py39, py310

comment:41 Changed 2 years ago by
Reviewers:  Matthias Koeppe, ... → Matthias Koeppe, Dima Pasechnik 

Status:  needs_review → positive_review 
OK, this works
comment:44 Changed 2 years ago by
Commit:  c948b02d1ec33cdc3a8bfc9603faf729fbb22402 → b1fe92979131e2ea2e357a37a1b57deb7051fc6a 

comment:45 Changed 2 years ago by
Commit:  b1fe92979131e2ea2e357a37a1b57deb7051fc6a → 8cd0bccfdfeba58331e92087b1f2bacf7248c9e4 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
6ef52d6  build/pkgs/python3/spkgconfigure.m4: Issue a deprecation warning for system python 3.6

cf55561  Merge branch 't/31192/installation_manual__fix_documentation_of_python_prerequisite__sage_bootstrap_python_' into t/31318/python3_spkg_configure_m4__add_deprecation_warning_regarding_system_python_3_6

0fb8646  README.md, src/doc/en/installation/source.rst: Mention/update version range for python3

8cd0bcc  Merge #31318

comment:46 Changed 2 years ago by
Dependencies:  #29890, #31419 → #29890, #31419, #31318 

Status:  needs_work → positive_review 
comment:47 Changed 2 years ago by
Branch:  u/mkoeppe/build/unvendorargparse → 8cd0bccfdfeba58331e92087b1f2bacf7248c9e4 

Resolution:  → fixed 
Status:  positive_review → closed 
I changed the directory to
SAGE_ROOT/build/sage_bootstrap
and checked out contents : ` . ├── cksum.py ├── cmdline.py ├── compat.py ├── config.py ├── download.py ├── env.py ├── init.py ├── levenshtein.py ├── logger.py ├── mirror_list.py ├── package.py ├── README ├── stdio.py ├── tarball.py └── updater.py`
There is no subdirectory named "compat".