Opened 6 years ago

Closed 7 months ago

#20023 closed task (fixed)

sage_bootstrap: Remove purported Python 2.6 support

Reported by: vbraun Owned by:
Priority: critical Milestone: sage-9.3
Component: build Keywords:
Cc: chapoton, dimpase, embray, fbissey, jdemeyer, slelievre, jhpalmieri Merged in:
Authors: Dima Pasechnik, Matthias Koeppe Reviewers: Matthias Koeppe, Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 8cd0bcc (Commits, GitHub, GitLab) Commit: 8cd0bccfdfeba58331e92087b1f2bacf7248c9e4
Dependencies: #29890, #31419, #31318 Stopgaps:

Status badges

Description (last modified by mkoeppe)

In this ticket, we

This is on top of #31419 so that we have to change README only once.

Change History (47)

comment:1 Changed 6 years ago by karandesai-96

I changed the directory to SAGE_ROOT/build/sage_bootstrap and checked out contents : ` . ├── cksum.py ├── cmdline.py ├── compat.py ├── config.py ├── download.py ├── env.py ├── init.py ├── levenshtein.py ├── logger.py ├── mirror_list.py ├── package.py ├── README ├── stdio.py ├── tarball.py └── updater.py

`

There is no subdirectory named "compat".

comment:2 Changed 6 years ago by embray

This can also help with #9536 since Python 2.7+ supports the --no-user-cfg option to setup.py/setup.cfg, which Python 2.6 does not (just thought of this since it's an issue I looked at recently).

comment:3 Changed 5 years ago by vbraun

  • Cc dimpase added
  • Dependencies set to #19984
  • Description modified (diff)
  • Summary changed from Remove Python 2.6 support to Remove Python 2.6 support at some future point

comment:4 Changed 5 years ago by leif

  • Milestone changed from sage-7.1 to sage-wishlist
  • Type changed from enhancement to task

comment:5 Changed 2 years ago by slelievre

  • Cc chapoton embray fbissey jdemeyer slelievre added

See #28000 for complete removal of Python 2 support.

comment:6 Changed 2 years ago by embray

I'm pretty sure Python 2.6 support is completely removed from sagelib itself, just not from sage_bootstrap.

comment:7 Changed 2 years ago by dimpase

should we clean up sage_bootstrap in this respect here? (this would mean to require system's Python 2.7 or better for building)

comment:8 Changed 2 years ago by slelievre

Removing the ability to bootstrap from Python 2.6 probably does not need to happen before we remove Python 2 support in sagelib.

comment:9 Changed 2 years ago by dimpase

From the brief look at the code, this is a change that may be done now, and after all noone must Python 2.6 now.

comment:10 Changed 2 years ago by fbissey

It's the default python on redhat/centos 6 and possibly some ancient debian. I'll note that redhat/centos 6 have access to newer python but someone with admin privileges and knowledge of software collections is needed.

comment:11 Changed 16 months ago by mkoeppe

  • Summary changed from Remove Python 2.6 support at some future point to sage_bootstrap: Remove Python 2.6 support at some future point

comment:12 Changed 16 months ago by dimpase

I'll make an experimental branch to remove vendored argparse

comment:13 Changed 16 months ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/build/unvendorargparse
  • Commit set to 2d0891df1a2df77fc7eb68e6b69015e05b25c38e
  • Dependencies #19984 deleted

New commits:

2d0891dremove vendored argparse

comment:15 Changed 16 months ago by dimpase

  • Status changed from new to needs_review

comment:16 Changed 16 months ago by mkoeppe

Also need to update build/tox.ini

comment:17 Changed 16 months ago by git

  • Commit changed from 2d0891df1a2df77fc7eb68e6b69015e05b25c38e to f734c8ea9a7629e4ed787c12b866d70ebfd5251f

Branch pushed to git repo; I updated commit sha1. New commits:

f734c8eremove py26 from tox

comment:18 Changed 16 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review
  • Summary changed from sage_bootstrap: Remove Python 2.6 support at some future point to sage_bootstrap: Remove Python 2.6 support

comment:19 Changed 16 months ago by mkoeppe

  • Milestone changed from sage-wishlist to sage-9.2
  • Status changed from positive_review to needs_work

comment:20 Changed 16 months ago by mkoeppe

sage-system-python should probably check that python is new enough.

comment:21 Changed 16 months ago by mkoeppe

  • Dependencies set to #29890

comment:22 Changed 16 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-pending
  • Status changed from needs_work to needs_review

comment:23 Changed 16 months ago by mkoeppe

  • Authors changed from Dima Pasechnik to Dima Pasechnik, Matthias Koeppe

comment:24 Changed 16 months ago by mkoeppe

  • Branch changed from u/dimpase/build/unvendorargparse to u/mkoeppe/build/unvendorargparse

comment:25 Changed 16 months ago by mkoeppe

  • Cc jhpalmieri added
  • Commit changed from f734c8ea9a7629e4ed787c12b866d70ebfd5251f to 5ff700a02cd06952b167b9aeb26888bbfc5c74cc

New commits:

1d36a2ebuild/bin/sage-system-python: Try python first
890ef67Merge branch 't/29890/build_bin_sage_system_python__try__python__first' into t/20023/build/unvendorargparse
5ff700abuild/bin/sage-system-python: Test that python has argparse

comment:26 Changed 16 months ago by mkoeppe

I set it to sage-pending because I think 9.2 may be too early to merge this ticket.

comment:27 Changed 12 months ago by dimpase

  • Milestone changed from sage-pending to sage-9.3

needs a rebase - set milestone to 9.3

comment:28 Changed 12 months ago by mkoeppe

  • Status changed from needs_review to needs_work

comment:29 Changed 12 months ago by mkoeppe

  • Priority changed from major to minor

comment:30 Changed 10 months ago by dimpase

it seems that the branch ought to remove build/sage_bootstrap/compat, no?

comment:31 Changed 10 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-pending

I think sage 9.3 is still too early for removing the support for building the distribution on systems that only have python 2.6. Setting the milestone back to pending

comment:32 Changed 8 months ago by mkoeppe

  • Description modified (diff)
  • Summary changed from sage_bootstrap: Remove Python 2.6 support to sage_bootstrap: Remove purported Python 2.6 support

comment:33 Changed 8 months ago by mkoeppe

  • Description modified (diff)
  • Milestone changed from sage-pending to sage-9.3
  • Priority changed from minor to critical

comment:34 Changed 8 months ago by git

  • Commit changed from 5ff700a02cd06952b167b9aeb26888bbfc5c74cc to 0f3d369ec518c5084ef17976b72498f8e694887a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5946eb4remove vendored argparse
5500d19remove py26 from tox
0f3d369build/bin/sage-bootstrap-python: Test that python has argparse

comment:35 Changed 8 months ago by git

  • Commit changed from 0f3d369ec518c5084ef17976b72498f8e694887a to 86c05e6412c95482fb46b5570b0e59e7b636c066

Branch pushed to git repo; I updated commit sha1. New commits:

86c05e6src/doc/en/installation/source.rst: sage-bootstrap-python cannot be 2.6

comment:36 Changed 8 months ago by git

  • Commit changed from 86c05e6412c95482fb46b5570b0e59e7b636c066 to 06873c2264c5a228eb8fe0ae7a7fa1b4b58fcc88

Branch pushed to git repo; I updated commit sha1. New commits:

5e810ddbuild/pkgs/python3: Update to 3.9.2
60d6433Merge #31419
06873c2README.md: Update Python requirement for build

comment:37 Changed 8 months ago by mkoeppe

  • Dependencies changed from #29890 to #29890, #31419
  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:38 Changed 8 months ago by mkoeppe

  • Reviewers changed from Matthias Koeppe to Matthias Koeppe, ...

comment:39 Changed 8 months ago by dimpase

should we also remove py33 from build/tox.ini ?

comment:40 Changed 8 months ago by git

  • Commit changed from 06873c2264c5a228eb8fe0ae7a7fa1b4b58fcc88 to c948b02d1ec33cdc3a8bfc9603faf729fbb22402

Branch pushed to git repo; I updated commit sha1. New commits:

c948b02build/tox.ini: Remove py33, add py39, py310

comment:41 Changed 8 months ago by dimpase

  • Reviewers changed from Matthias Koeppe, ... to Matthias Koeppe, Dima Pasechnik
  • Status changed from needs_review to positive_review

OK, this works

comment:42 Changed 8 months ago by mkoeppe

Thanks.

comment:43 Changed 8 months ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:44 Changed 8 months ago by git

  • Commit changed from c948b02d1ec33cdc3a8bfc9603faf729fbb22402 to b1fe92979131e2ea2e357a37a1b57deb7051fc6a

Branch pushed to git repo; I updated commit sha1. New commits:

92533b8Merge tag '9.3.beta8' into t/20023/build/unvendorargparse
0cac965build/pkgs/ecl: Update to 21.2.1, remove patches included in new version
6a62484delete all merged upstream patches: MR 210, MR 231
b1fe929Merge #31336

comment:45 Changed 8 months ago by git

  • Commit changed from b1fe92979131e2ea2e357a37a1b57deb7051fc6a to 8cd0bccfdfeba58331e92087b1f2bacf7248c9e4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6ef52d6build/pkgs/python3/spkg-configure.m4: Issue a deprecation warning for system python 3.6
cf55561Merge branch 't/31192/installation_manual__fix_documentation_of_python_prerequisite__sage_bootstrap_python_' into t/31318/python3_spkg_configure_m4__add_deprecation_warning_regarding_system_python_3_6
0fb8646README.md, src/doc/en/installation/source.rst: Mention/update version range for python3
8cd0bccMerge #31318

comment:46 Changed 8 months ago by mkoeppe

  • Dependencies changed from #29890, #31419 to #29890, #31419, #31318
  • Status changed from needs_work to positive_review

comment:47 Changed 7 months ago by vbraun

  • Branch changed from u/mkoeppe/build/unvendorargparse to 8cd0bccfdfeba58331e92087b1f2bacf7248c9e4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.