Opened 5 years ago
Closed 5 years ago
#20012 closed defect (fixed)
Really deprecate CFF/ContinuedFractionField
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.1 |
Component: | misc | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Vincent Delecroix |
Report Upstream: | N/A | Work issues: | |
Branch: | 7f201e6 (Commits, GitHub, GitLab) | Commit: | 7f201e65fd908d337baef16cf7590f06ac323a84 |
Dependencies: | Stopgaps: |
Description
The class ContinuedFractionField
is documented as being deprecated (see #14567) but it doesn't actually raise any warnings when used.
Change History (9)
comment:1 Changed 5 years ago by
- Branch set to u/jdemeyer/deprecate_cff_continuedfractionfield
comment:2 Changed 5 years ago by
- Commit set to 7f201e65fd908d337baef16cf7590f06ac323a84
- Status changed from new to needs_review
comment:3 Changed 5 years ago by
- Summary changed from Deprecate CFF/ContinuedFractionField to Really deprecate CFF/ContinuedFractionField
comment:4 follow-up: ↓ 5 Changed 5 years ago by
Couldn't we deprecate more? For example this works fine.
sage: CFF QQ as continued fractions sage: CFF.cardinality() +Infinity
I would at least change the import for a lazy_import with deprecation in all.py
.
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 5 years ago by
Replying to vdelecroix:
Couldn't we deprecate more?
That doesn't work because of #19628. The current branch gives a deprecation warning whenever an element of CFF
is constructed. I think this is sufficient: you cannot really do anything useful with CFF
without creating elements.
comment:6 in reply to: ↑ 5 Changed 5 years ago by
Replying to jdemeyer:
Replying to vdelecroix:
Couldn't we deprecate more?
That doesn't work because of #19628. The current branch gives a deprecation warning whenever an element of
CFF
is constructed. I think this is sufficient: you cannot really do anything useful withCFF
without creating elements.
Agreed. I just want to avoid people complaining about deletion because it was not deprecated...
comment:7 Changed 5 years ago by
And regardless of this ticket, it's already documented as deprecated.
comment:8 Changed 5 years ago by
- Reviewers set to Vincent Delecroix
- Status changed from needs_review to positive_review
comment:9 Changed 5 years ago by
- Branch changed from u/jdemeyer/deprecate_cff_continuedfractionfield to 7f201e65fd908d337baef16cf7590f06ac323a84
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Deprecate CFF/ContinuedFractionField